From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86945C10F03 for ; Tue, 23 Apr 2019 15:02:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D04021773 for ; Tue, 23 Apr 2019 15:02:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D04021773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:55078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIww3-00072W-Gw for qemu-devel@archiver.kernel.org; Tue, 23 Apr 2019 11:02:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIwv4-0006MA-Mq for qemu-devel@nongnu.org; Tue, 23 Apr 2019 11:01:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIwuy-0003iu-Fb for qemu-devel@nongnu.org; Tue, 23 Apr 2019 11:01:12 -0400 Received: from indium.canonical.com ([91.189.90.7]:60876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIwuy-0003hd-8e for qemu-devel@nongnu.org; Tue, 23 Apr 2019 11:01:08 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1hIwut-0001hF-Tv for ; Tue, 23 Apr 2019 15:01:04 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id CA84F2E817A for ; Tue, 23 Apr 2019 15:01:02 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Tue, 23 Apr 2019 14:48:44 -0000 From: Jakub Jermar <1825311@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug-Tags: mips X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: jakub X-Launchpad-Bug-Reporter: Jakub Jermar (jakub) X-Launchpad-Bug-Modifier: Jakub Jermar (jakub) References: <155557460746.17507.17649109204793492383.malonedeb@soybean.canonical.com> Message-Id: <155603092465.6530.17158756071412067771.malone@chaenomeles.canonical.com> X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="18928"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: f820afad3fc110870ffc0dc42bb53ba170e2cf2a X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 91.189.90.7 Subject: [Qemu-devel] [Bug 1825311] Re: mips_cpu_handle_mmu_fault renders all accessed pages executable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1825311 <1825311@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190423144844.VjsT5MTrVp9P8cCqzDU-R8h5GHCzDBdiHq08-s3H-Ag@z> I am attaching a reproducer image and script. Unpatched execution ends like this: ... TAP TEST START 1..2 not ok 1 NonExecutable::ElfDataIsNotExecutable # Assertion failed /home/jermar/Kernkonzept/software/l4/pkg/l4re-core/test/= moe/test_nx.cc:103 # Expected: -(L4_EIPC_LO + l4_ipc_error(tag, l4_utcb())) >=3D 0 # Actual: -2003 (Receive timeout) # There was no IPC error. # Assertion failed /home/jermar/Kernkonzept/software/l4/pkg/l4re-core/test/= moe/test_nx.cc:125 # Expected equality of these values: # pfa # Which is: 360 # (l4_addr_t)execute_data # Which is: 17633344 # The page fault occured at the expected location. not ok 2 NonExecutable::StackIsNotExecutable # Assertion failed /home/jermar/Kernkonzept/software/l4/pkg/l4re-core/test/= moe/test_nx.cc:103 # Expected: -(L4_EIPC_LO + l4_ipc_error(tag, l4_utcb())) >=3D 0 # Actual: -2003 (Receive timeout) # There was no IPC error. # Assertion failed /home/jermar/Kernkonzept/software/l4/pkg/l4re-core/test/= moe/test_nx.cc:144 # Expected equality of these values: # pfa # Which is: 4358144 # stack_func # Which is: 4276000 # The page fault occured at the expected location. TAP TEST FINISHED With the proposed patch applied, the execution should end with something like this: ... TAP TEST START 1..2 ok 1 NonExecutable::ElfDataIsNotExecutable ok 2 NonExecutable::StackIsNotExecutable TAP TEST FINISHED ** Attachment added: "Image and script for reproducing this bug." https://bugs.launchpad.net/qemu/+bug/1825311/+attachment/5258264/+files/= reproducer.tar.xz -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1825311 Title: mips_cpu_handle_mmu_fault renders all accessed pages executable Status in QEMU: New Bug description: On MIPS, data accesses to pages mapped in the TLB result in mips_cpu_handle_mmu_fault() marking the page unconditionally executable, even if the TLB entry has the XI bit set. Later on, when there is an attempt to execute this page, no exception is generated, even though TLBXI is expected. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1825311/+subscriptions