From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_HK_NAME_DR, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E1EAC04A6B for ; Wed, 8 May 2019 10:27:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C0B421479 for ; Wed, 8 May 2019 10:27:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C0B421479 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:34430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOJnH-0003b4-3s for qemu-devel@archiver.kernel.org; Wed, 08 May 2019 06:27:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOJmO-0003BF-Ub for qemu-devel@nongnu.org; Wed, 08 May 2019 06:26:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOJmN-0002HJ-Kt for qemu-devel@nongnu.org; Wed, 08 May 2019 06:26:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40294) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOJmN-0002EA-Cg; Wed, 08 May 2019 06:26:27 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9705D4628E; Wed, 8 May 2019 10:26:25 +0000 (UTC) Received: from work-vm (ovpn-117-175.ams2.redhat.com [10.36.117.175]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 042451001DCD; Wed, 8 May 2019 10:26:23 +0000 (UTC) Date: Wed, 8 May 2019 11:26:21 +0100 From: "Dr. David Alan Gilbert" To: Markus Armbruster Message-ID: <20190508102621.GD2718@work-vm> References: <20190501053522.10967-1-sjitindarsingh@gmail.com> <87woj2cyhu.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87woj2cyhu.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 08 May 2019 10:26:25 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Suraj Jitindar Singh , david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Markus Armbruster (armbru@redhat.com) wrote: > Suraj Jitindar Singh writes: > > > Add a monitor command "dump-stack" to be used to dump the stack for the > > current cpu. > > I guess this is just for debugging. Correct? > > Shouldn't this be "info stack", to match "info registers" and "info > cpustats"? Since this is primarily about walking the guests stack frames and not walking qemu internal data structures, I think it's probably OK to be a dump-stack rather than an info subcommand. Dave > > > > Signed-off-by: Suraj Jitindar Singh > > --- > > hmp-commands.hx | 13 +++++++++++++ > > hmp.h | 1 + > > include/qom/cpu.h | 10 ++++++++++ > > monitor.c | 12 ++++++++++++ > > qom/cpu.c | 10 ++++++++++ > > 5 files changed, 46 insertions(+) > > > > diff --git a/hmp-commands.hx b/hmp-commands.hx > > index 9b4035965c..965ccdea28 100644 > > --- a/hmp-commands.hx > > +++ b/hmp-commands.hx > > @@ -862,6 +862,19 @@ ETEXI > > }, > > > > STEXI > > +@item dump-stack > > +@findex dump-stack > > +dump stack of the cpu > > +ETEXI > > + { > > + .name = "dump-stack", > > + .args_type = "", > > + .params = "", > > + .help = "dump stack", > > + .cmd = hmp_dumpstack, > > + }, > > + > > +STEXI > > @item pmemsave @var{addr} @var{size} @var{file} > > @findex pmemsave > > save to disk physical memory dump starting at @var{addr} of size @var{size}. > > diff --git a/hmp.h b/hmp.h > > index 43617f2646..e6edf1215c 100644 > > --- a/hmp.h > > +++ b/hmp.h > > @@ -51,6 +51,7 @@ void hmp_announce_self(Monitor *mon, const QDict *qdict); > > void hmp_cpu(Monitor *mon, const QDict *qdict); > > void hmp_memsave(Monitor *mon, const QDict *qdict); > > void hmp_pmemsave(Monitor *mon, const QDict *qdict); > > +void hmp_dumpstack(Monitor *mon, const QDict *qdict); > > void hmp_ringbuf_write(Monitor *mon, const QDict *qdict); > > void hmp_ringbuf_read(Monitor *mon, const QDict *qdict); > > void hmp_cont(Monitor *mon, const QDict *qdict); > > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > > index 08abcbd3fe..f2e83e9918 100644 > > --- a/include/qom/cpu.h > > +++ b/include/qom/cpu.h > > @@ -181,6 +181,7 @@ typedef struct CPUClass { > > int (*memory_rw_debug)(CPUState *cpu, vaddr addr, > > uint8_t *buf, int len, bool is_write); > > void (*dump_state)(CPUState *cpu, FILE *, int flags); > > + void (*dump_stack)(CPUState *cpu, FILE *f); > > GuestPanicInformation* (*get_crash_info)(CPUState *cpu); > > void (*dump_statistics)(CPUState *cpu, int flags); > > int64_t (*get_arch_id)(CPUState *cpu); > > @@ -568,6 +569,15 @@ enum CPUDumpFlags { > > void cpu_dump_state(CPUState *cpu, FILE *f, int flags); > > > > /** > > + * cpu_dump_stack: > > + * @cpu: The CPU whose stack is to be dumped. > > + * @f: If non-null, dump to this stream, else to current print sink. > > + * > > + * Dumps CPU stack. > > + */ > > +void cpu_dump_stack(CPUState *cpu, FILE *f); > > + > > +/** > > * cpu_dump_statistics: > > * @cpu: The CPU whose state is to be dumped. > > * @flags: Flags what to dump. > > diff --git a/monitor.c b/monitor.c > > index 9b5f10b475..dbec2e4376 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -1299,6 +1299,18 @@ static void hmp_info_registers(Monitor *mon, const QDict *qdict) > > } > > } > > > > +void hmp_dumpstack(Monitor *mon, const QDict *qdict) > > +{ > > + CPUState *cs = mon_get_cpu(); > > + > > + if (!cs) { > > + monitor_printf(mon, "No CPU available\n"); > > + return; > > + } > > + > > + cpu_dump_stack(cs, NULL); > > +} > > + > > #ifdef CONFIG_TCG > > static void hmp_info_jit(Monitor *mon, const QDict *qdict) > > { > > diff --git a/qom/cpu.c b/qom/cpu.c > > index 3c5493c96c..0dc10004f4 100644 > > --- a/qom/cpu.c > > +++ b/qom/cpu.c > > @@ -230,6 +230,16 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags) > > } > > } > > > > +void cpu_dump_stack(CPUState *cpu, FILE *f) > > +{ > > + CPUClass *cc = CPU_GET_CLASS(cpu); > > + > > + if (cc->dump_stack) { > > + cpu_synchronize_state(cpu); > > + cc->dump_stack(cpu, f); > > + } > > +} > > Silently does nothing when the CPU doesn't implement dump_stack(). > Matches "info registers" and "info cpustats". Awful UI, but at least > it's consistently awful. > > > + > > void cpu_dump_statistics(CPUState *cpu, int flags) > > { > > CPUClass *cc = CPU_GET_CLASS(cpu); -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK