From: Wei Yang <richardw.yang@linux.intel.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer
Date: Tue, 11 Jun 2019 16:25:20 +0800 [thread overview]
Message-ID: <20190611082520.GA11125@richard> (raw)
In-Reply-To: <20190402003106.17614-1-richardw.yang@linux.intel.com>
On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>
>Remove this unnecessary field.
>
>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Hi, David
Are you willing to pick up this one?
>---
> migration/migration.c | 1 -
> migration/migration.h | 1 -
> 2 files changed, 2 deletions(-)
>
>diff --git a/migration/migration.c b/migration/migration.c
>index dea7078bf4..c929cf8d0f 100644
>--- a/migration/migration.c
>+++ b/migration/migration.c
>@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
> * parameters/capabilities that the user set, and
> * locks.
> */
>- s->bytes_xfer = 0;
> s->cleanup_bh = 0;
> s->to_dst_file = NULL;
> s->rp_state.from_dst_file = NULL;
>diff --git a/migration/migration.h b/migration/migration.h
>index 852eb3c4e9..b9efbe9168 100644
>--- a/migration/migration.h
>+++ b/migration/migration.h
>@@ -116,7 +116,6 @@ struct MigrationState
> DeviceState parent_obj;
>
> /*< public >*/
>- size_t bytes_xfer;
> QemuThread thread;
> QEMUBH *cleanup_bh;
> QEMUFile *to_dst_file;
>--
>2.19.1
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-06-11 8:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 0:31 [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer Wei Yang
2019-06-11 8:25 ` Wei Yang [this message]
2019-06-11 8:33 ` Juan Quintela
2019-06-11 8:50 ` Wei Yang
2019-06-21 7:43 ` Wei Yang
2019-07-17 1:14 ` Wei Yang
2019-07-19 18:05 ` Dr. David Alan Gilbert
2019-07-20 1:36 ` Wei Yang
2019-08-07 18:46 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611082520.GA11125@richard \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).