From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79EF5C31E44 for ; Wed, 12 Jun 2019 02:13:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51DC620866 for ; Wed, 12 Jun 2019 02:13:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51DC620866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haslh-0005ZH-Fp for qemu-devel@archiver.kernel.org; Tue, 11 Jun 2019 22:13:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58463) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hasku-0004fE-UB for qemu-devel@nongnu.org; Tue, 11 Jun 2019 22:12:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haskt-0005pn-Nm for qemu-devel@nongnu.org; Tue, 11 Jun 2019 22:12:52 -0400 Received: from mga12.intel.com ([192.55.52.136]:23867) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1haskt-0005nO-E7; Tue, 11 Jun 2019 22:12:51 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 19:12:44 -0700 X-ExtLoop1: 1 Received: from npg-dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.151]) by fmsmga008.fm.intel.com with ESMTP; 11 Jun 2019 19:12:43 -0700 Date: Wed, 12 Jun 2019 10:11:33 +0800 From: Tiwei Bie To: Jason Wang Message-ID: <20190612021132.GA23690@___> References: <20190611065137.16329-1-tiwei.bie@intel.com> <15f37c7d-5246-e093-e92c-1bd6ff77786a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <15f37c7d-5246-e093-e92c-1bd6ff77786a@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.136 Subject: Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 11, 2019 at 03:22:47PM +0800, Jason Wang wrote: > > On 2019/6/11 下午2:51, Tiwei Bie wrote: > > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of > > vhost-user backend. But it will be advertised to guest driver > > as long as it's enabled by users in QEMU, while it's not > > supported by vhost-user backend. This patch fixes this issue. > > > > Fixes: 72018d1e1917 ("vhost-user: ignore qemu-only features") > > > My understanding is if may want to revert this patch. > > > > Cc: qemu-stable@nongnu.org > > > > Signed-off-by: Tiwei Bie > > --- > > It's not clear in the spec that, whether vlan filtering is > > also best-effort: > > https://github.com/oasis-tcs/virtio-spec/blob/37057052e7/content.tex#L3372 > > > It should be a bug of the code, we should consider to implement ctrl command > for vhost-user. Yeah, we need to pass these information to backends if we want to make it possible to support it in vhost-user. > > Thanks > > > > > > hw/net/vhost_net.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > > index a6b719035c..1444fc9230 100644 > > --- a/hw/net/vhost_net.c > > +++ b/hw/net/vhost_net.c > > @@ -75,6 +75,8 @@ static const int user_feature_bits[] = { > > VIRTIO_NET_F_MTU, > > VIRTIO_F_IOMMU_PLATFORM, > > + VIRTIO_NET_F_CTRL_VLAN, > > + > > /* This bit implies RARP isn't sent by QEMU out of band */ > > VIRTIO_NET_F_GUEST_ANNOUNCE,