* [Qemu-devel] [PATCH] configure: use valid args testing sem_timedwait
@ 2019-06-17 11:41 Daniel P. Berrangé
2019-06-17 12:21 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-06-26 16:27 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2019-06-17 11:41 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Peter Maydell, Daniel P. Berrangé
The sem_timedwait function has been annotated as requiring
non-null args in latest header files from GCC snapshot
representing the future 2.30 release.
This causes configure to fail when -Werror is used:
config-temp/qemu-conf.c: In function ‘main’:
config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 1) [-Werror=nonnull]
2 | int main(void) { return sem_timedwait(0, 0); }
| ^~~~~~~~~~~~~
config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 2) [-Werror=nonnull]
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index b091b82cb3..6632d05fc7 100755
--- a/configure
+++ b/configure
@@ -5139,7 +5139,7 @@ fi
sem_timedwait=no
cat > $TMPC << EOF
#include <semaphore.h>
-int main(void) { return sem_timedwait(0, 0); }
+int main(void) { sem_t s; struct timespec t = {0}; return sem_timedwait(&s, &t); }
EOF
if compile_prog "" "" ; then
sem_timedwait=yes
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: use valid args testing sem_timedwait
2019-06-17 11:41 [Qemu-devel] [PATCH] configure: use valid args testing sem_timedwait Daniel P. Berrangé
@ 2019-06-17 12:21 ` Laurent Vivier
2019-06-26 16:27 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-06-17 12:21 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel; +Cc: qemu-trivial, Peter Maydell
Le 17/06/2019 à 13:41, Daniel P. Berrangé a écrit :
> The sem_timedwait function has been annotated as requiring
> non-null args in latest header files from GCC snapshot
> representing the future 2.30 release.
>
> This causes configure to fail when -Werror is used:
>
> config-temp/qemu-conf.c: In function ‘main’:
> config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 1) [-Werror=nonnull]
> 2 | int main(void) { return sem_timedwait(0, 0); }
> | ^~~~~~~~~~~~~
> config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 2) [-Werror=nonnull]
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index b091b82cb3..6632d05fc7 100755
> --- a/configure
> +++ b/configure
> @@ -5139,7 +5139,7 @@ fi
> sem_timedwait=no
> cat > $TMPC << EOF
> #include <semaphore.h>
> -int main(void) { return sem_timedwait(0, 0); }
> +int main(void) { sem_t s; struct timespec t = {0}; return sem_timedwait(&s, &t); }
> EOF
> if compile_prog "" "" ; then
> sem_timedwait=yes
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: use valid args testing sem_timedwait
2019-06-17 11:41 [Qemu-devel] [PATCH] configure: use valid args testing sem_timedwait Daniel P. Berrangé
2019-06-17 12:21 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2019-06-26 16:27 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-06-26 16:27 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel; +Cc: qemu-trivial, Peter Maydell
Le 17/06/2019 à 13:41, Daniel P. Berrangé a écrit :
> The sem_timedwait function has been annotated as requiring
> non-null args in latest header files from GCC snapshot
> representing the future 2.30 release.
>
> This causes configure to fail when -Werror is used:
>
> config-temp/qemu-conf.c: In function ‘main’:
> config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 1) [-Werror=nonnull]
> 2 | int main(void) { return sem_timedwait(0, 0); }
> | ^~~~~~~~~~~~~
> config-temp/qemu-conf.c:2:25: error: null argument where non-null required (argument 2) [-Werror=nonnull]
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index b091b82cb3..6632d05fc7 100755
> --- a/configure
> +++ b/configure
> @@ -5139,7 +5139,7 @@ fi
> sem_timedwait=no
> cat > $TMPC << EOF
> #include <semaphore.h>
> -int main(void) { return sem_timedwait(0, 0); }
> +int main(void) { sem_t s; struct timespec t = {0}; return sem_timedwait(&s, &t); }
> EOF
> if compile_prog "" "" ; then
> sem_timedwait=yes
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-26 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 11:41 [Qemu-devel] [PATCH] configure: use valid args testing sem_timedwait Daniel P. Berrangé
2019-06-17 12:21 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-06-26 16:27 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).