From: Eduardo Habkost <ehabkost@redhat.com>
To: Roman Kagan <rkagan@virtuozzo.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts
Date: Tue, 18 Jun 2019 19:54:40 -0300 [thread overview]
Message-ID: <20190618225440.GM19178@habkost.net> (raw)
In-Reply-To: <20190615200505.31348-1-ehabkost@redhat.com>
On Sat, Jun 15, 2019 at 05:05:05PM -0300, Eduardo Habkost wrote:
> The current default value for hv-spinlocks is 0xFFFFFFFF (meaning
> "never retry"). However, the value is stored as a signed
> integer, making the getter of the hv-spinlocks QOM property
> return -1 instead of 0xFFFFFFFF.
>
> Fix this by changing the type of X86CPU::hyperv_spinlock_attempts
> to uint32_t. This has no visible effect to guest operating
> systems, affecting just the behavior of the QOM getter.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Queued on x86-next.
--
Eduardo
prev parent reply other threads:[~2019-06-18 22:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 20:05 [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts Eduardo Habkost
2019-06-17 6:59 ` Vitaly Kuznetsov
2019-06-17 13:48 ` Roman Kagan
2019-06-17 14:23 ` Eduardo Habkost
2019-06-17 17:32 ` Roman Kagan
2019-06-17 17:49 ` Eduardo Habkost
2019-06-18 1:24 ` Vadim Rozenfeld
2019-06-18 10:35 ` Roman Kagan
2019-06-18 11:08 ` Roman Kagan
2019-06-18 11:17 ` Vadim Rozenfeld
2019-06-18 22:54 ` Eduardo Habkost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618225440.GM19178@habkost.net \
--to=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=rth@twiddle.net \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).