From: Igor Mammedov <imammedo@redhat.com>
To: Dongjiu Geng <gengdongjiu@huawei.com>
Cc: peter.maydell@linaro.org, ehabkost@redhat.com,
kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com,
qemu-devel@nongnu.org, linuxarm@huawei.com,
shannon.zhaosl@gmail.com, zhengxiang9@huawei.com,
qemu-arm@nongnu.org, james.morse@arm.com, xuwei5@huawei.com,
jonathan.cameron@huawei.com, pbonzini@redhat.com,
lersek@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v17 03/10] acpi: add build_append_ghes_notify() helper for Hardware Error Notification
Date: Mon, 24 Jun 2019 13:21:49 +0200 [thread overview]
Message-ID: <20190624132149.3c79fadc@redhat.com> (raw)
In-Reply-To: <1557832703-42620-4-git-send-email-gengdongjiu@huawei.com>
On Tue, 14 May 2019 04:18:16 -0700
Dongjiu Geng <gengdongjiu@huawei.com> wrote:
> It will help to add Hardware Error Notification to ACPI tables
> without using packed C structures and avoid endianness
> issues as API doesn't need explicit conversion.
>
> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
> ---
> hw/acpi/aml-build.c | 22 ++++++++++++++++++++++
> include/hw/acpi/aml-build.h | 8 ++++++++
> 2 files changed, 30 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 555c24f..fb53f21 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -274,6 +274,28 @@ void build_append_gas(GArray *table, AmlAddressSpace as,
> build_append_int_noprefix(table, address, 8);
> }
>
> +/* Hardware Error Notification
> + * ACPI 4.0: 17.3.2.7 Hardware Error Notification
> + */
> +void build_append_ghes_notify(GArray *table, const uint8_t type,
> + uint8_t length, uint16_t config_write_enable,
> + uint32_t poll_interval, uint32_t vector,
> + uint32_t polling_threshold_value,
> + uint32_t polling_threshold_window,
> + uint32_t error_threshold_value,
> + uint32_t error_threshold_window)
> +{
> + build_append_int_noprefix(table, type, 1); /* type */
comment should be verbatim copy from spec, in this case /* Type */
also do the same for other fields below
other than that patch looks good to me
> + build_append_int_noprefix(table, length, 1);
> + build_append_int_noprefix(table, config_write_enable, 2);
> + build_append_int_noprefix(table, poll_interval, 4);
> + build_append_int_noprefix(table, vector, 4);
> + build_append_int_noprefix(table, polling_threshold_value, 4);
> + build_append_int_noprefix(table, polling_threshold_window, 4);
> + build_append_int_noprefix(table, error_threshold_value, 4);
> + build_append_int_noprefix(table, error_threshold_window, 4);
> +}
> +
> /*
> * Build NAME(XXXX, 0x00000000) where 0x00000000 is encoded as a dword,
> * and return the offset to 0x00000000 for runtime patching.
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 1a563ad..90c8ef8 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -411,6 +411,14 @@ build_append_gas_from_struct(GArray *table, const struct AcpiGenericAddress *s)
> s->access_width, s->address);
> }
>
> +void build_append_ghes_notify(GArray *table, const uint8_t type,
> + uint8_t length, uint16_t config_write_enable,
> + uint32_t poll_interval, uint32_t vector,
> + uint32_t polling_threshold_value,
> + uint32_t polling_threshold_window,
> + uint32_t error_threshold_value,
> + uint32_t error_threshold_window);
> +
> void build_srat_memory(AcpiSratMemoryAffinity *numamem, uint64_t base,
> uint64_t len, int node, MemoryAffinityFlags flags);
>
next prev parent reply other threads:[~2019-06-24 11:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 11:18 [Qemu-devel] [PATCH v17 00/10] Add ARMv8 RAS virtualization support in QEMU Dongjiu Geng
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 01/10] hw/arm/virt: Add RAS platform version for migration Dongjiu Geng
2019-06-20 12:04 ` Igor Mammedov
2019-06-24 12:19 ` gengdongjiu
2019-06-25 13:16 ` Igor Mammedov
2019-06-25 13:29 ` gengdongjiu
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition Dongjiu Geng
2019-05-29 3:40 ` Michael S. Tsirkin
2019-05-30 14:58 ` gengdongjiu
2019-06-20 12:10 ` Igor Mammedov
2019-06-20 14:04 ` gengdongjiu
2019-06-20 15:09 ` Igor Mammedov
2019-06-20 17:17 ` gengdongjiu
2019-06-24 11:16 ` Igor Mammedov
2019-06-25 9:56 ` gengdongjiu
2019-06-25 13:33 ` Igor Mammedov
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 03/10] acpi: add build_append_ghes_notify() helper for Hardware Error Notification Dongjiu Geng
2019-06-24 11:21 ` Igor Mammedov [this message]
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 04/10] acpi: add build_append_ghes_generic_data() helper for Generic Error Data Entry Dongjiu Geng
2019-06-20 12:28 ` Igor Mammedov
2019-06-24 12:37 ` gengdongjiu
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 05/10] acpi: add build_append_ghes_generic_status() helper for Generic Error Status Block Dongjiu Geng
2019-06-20 12:42 ` Igor Mammedov
2019-06-25 12:11 ` gengdongjiu
2019-06-25 13:41 ` Igor Mammedov
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 06/10] docs: APEI GHES generation and CPER record description Dongjiu Geng
2019-06-24 11:39 ` Igor Mammedov
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 07/10] ACPI: Add APEI GHES table generation support Dongjiu Geng
2019-05-29 3:37 ` Michael S. Tsirkin
2019-05-30 14:47 ` gengdongjiu
2019-06-06 13:43 ` Jonathan Cameron
2019-06-24 12:27 ` Igor Mammedov
2019-06-25 13:48 ` gengdongjiu
2019-06-26 14:25 ` Igor Mammedov
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 08/10] KVM: Move related hwpoison page functions to accel/kvm/ folder Dongjiu Geng
2019-06-24 12:32 ` Igor Mammedov
2019-06-25 12:28 ` gengdongjiu
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 09/10] target-arm: kvm64: inject synchronous External Abort Dongjiu Geng
2019-05-14 11:18 ` [Qemu-devel] [PATCH v17 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Dongjiu Geng
2019-06-06 13:31 ` Jonathan Cameron
2019-06-24 13:08 ` Igor Mammedov
2019-06-25 12:24 ` gengdongjiu
2019-06-25 13:32 ` Igor Mammedov
2019-05-15 9:40 ` [Qemu-devel] [PATCH v17 00/10] Add ARMv8 RAS virtualization support in QEMU gengdongjiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624132149.3c79fadc@redhat.com \
--to=imammedo@redhat.com \
--cc=ehabkost@redhat.com \
--cc=gengdongjiu@huawei.com \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=shannon.zhaosl@gmail.com \
--cc=xuwei5@huawei.com \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).