qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: <qemu-devel@nongnu.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org,
	Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 7/8] Revert xen/io/ring.h of "Clean up a few header guard symbols"
Date: Mon, 24 Jun 2019 16:32:56 +0100	[thread overview]
Message-ID: <20190624153257.20163-8-anthony.perard@citrix.com> (raw)
In-Reply-To: <20190624153257.20163-1-anthony.perard@citrix.com>

This reverts changes to include/hw/xen/io/ring.h from commit
37677d7db39a3c250ad661d00fb7c3b59d047b1f.

Following 37677d7db3 "Clean up a few header guard symbols", QEMU start
to fail to build:

In file included from ~/xen/tools/../tools/include/xen/io/blkif.h:31:0,
                 from ~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:5,
                 from ~/xen/tools/qemu-xen-dir/hw/block/xen-block.c:22:
~/xen/tools/../tools/include/xen/io/ring.h:68:0: error: "__CONST_RING_SIZE" redefined [-Werror]
 #define __CONST_RING_SIZE(_s, _sz) \

In file included from ~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:4:0,
                 from ~/xen/tools/qemu-xen-dir/hw/block/xen-block.c:22:
~/xen/tools/qemu-xen-dir/include/hw/xen/io/ring.h:66:0: note: this is the location of the previous definition
 #define __CONST_RING_SIZE(_s, _sz) \

The issue is that some public xen headers have been imported (by
f65eadb639 "xen: import ring.h from xen") but not all. With the change
in the guards symbole, the ring.h header start to be imported twice.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Message-Id: <20190621105441.3025-2-anthony.perard@citrix.com>
---
 include/hw/xen/io/ring.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/hw/xen/io/ring.h b/include/hw/xen/io/ring.h
index 62abfd7a6e..1adacf09f9 100644
--- a/include/hw/xen/io/ring.h
+++ b/include/hw/xen/io/ring.h
@@ -24,8 +24,8 @@
  * Tim Deegan and Andrew Warfield November 2004.
  */
 
-#ifndef XEN_PUBLIC_IO_RING_H
-#define XEN_PUBLIC_IO_RING_H
+#ifndef __XEN_PUBLIC_IO_RING_H__
+#define __XEN_PUBLIC_IO_RING_H__
 
 /*
  * When #include'ing this header, you need to provide the following
@@ -469,7 +469,7 @@ struct name##_data_intf {                                                     \
 };                                                                            \
 DEFINE_XEN_FLEX_RING(name)
 
-#endif /* XEN_PUBLIC_IO_RING_H */
+#endif /* __XEN_PUBLIC_IO_RING_H__ */
 
 /*
  * Local variables:
-- 
Anthony PERARD



  parent reply	other threads:[~2019-06-24 15:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-24 15:32 [Qemu-devel] [PULL 0/8] xen queue 2019-06-24 Anthony PERARD
2019-06-24 15:32 ` [Qemu-devel] [PULL 1/8] xen-block: support feature-large-sector-size Anthony PERARD
2019-06-24 15:32 ` [Qemu-devel] [PULL 2/8] xen-bus: use a separate fd for each event channel Anthony PERARD
2019-06-24 15:32 ` [Qemu-devel] [PULL 3/8] xen-bus: allow AioContext to be specified " Anthony PERARD
2019-06-24 15:32 ` [Qemu-devel] [PULL 4/8] xen-bus / xen-block: add support for event channel polling Anthony PERARD
2019-06-24 15:32 ` [Qemu-devel] [PULL 5/8] xen: Avoid VLA Anthony PERARD
2019-06-24 15:32 ` [Qemu-devel] [PULL 6/8] xen: Drop includes of xen/hvm/params.h Anthony PERARD
2019-06-24 15:32 ` Anthony PERARD [this message]
2019-06-24 15:32 ` [Qemu-devel] [PULL 8/8] xen: Import other xen/io/*.h Anthony PERARD
2019-06-24 16:10 ` [Qemu-devel] [Xen-devel] [PULL 0/8] xen queue 2019-06-24 no-reply
2019-06-24 16:28 ` no-reply
2019-06-24 16:34 ` no-reply
2019-06-24 16:48 ` no-reply
2019-06-24 17:19 ` no-reply
2019-07-01 12:45 ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190624153257.20163-8-anthony.perard@citrix.com \
    --to=anthony.perard@citrix.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).