From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3451CC4646C for ; Tue, 25 Jun 2019 03:12:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D6C420665 for ; Tue, 25 Jun 2019 03:12:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D6C420665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfbsk-0006Cr-8D for qemu-devel@archiver.kernel.org; Mon, 24 Jun 2019 23:12:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36227) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfbrC-0004tX-44 for qemu-devel@nongnu.org; Mon, 24 Jun 2019 23:10:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfbrA-0001tN-WE for qemu-devel@nongnu.org; Mon, 24 Jun 2019 23:10:54 -0400 Received: from mga01.intel.com ([192.55.52.88]:12049) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfbrA-0001mS-JU for qemu-devel@nongnu.org; Mon, 24 Jun 2019 23:10:52 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jun 2019 20:10:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,413,1557212400"; d="scan'208";a="244928048" Received: from joy-optiplex-7040.sh.intel.com (HELO joy-OptiPlex-7040) ([10.239.13.9]) by orsmga001.jf.intel.com with ESMTP; 24 Jun 2019 20:10:42 -0700 Date: Mon, 24 Jun 2019 23:04:49 -0400 From: Yan Zhao To: Auger Eric Message-ID: <20190625030449.GB6971@joy-OptiPlex-7040> References: <1561364781-6897-1-git-send-email-yan.y.zhao@intel.com> <1561365559-10235-1-git-send-email-yan.y.zhao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 Subject: Re: [Qemu-devel] [PATCH v3] memory: warning on out of scope notification X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yan Zhao Cc: "pbonzini@redhat.com" , "qemu-devel@nongnu.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jun 24, 2019 at 06:11:11PM +0800, Auger Eric wrote: > Hi Yan, > > On 6/24/19 10:39 AM, Yan Zhao wrote: > > if an entry has parts out of scope of notifier's range, print warning > > message. > > > > Out of scope mapping/unmapping would cause problem, as in below case: > > > > 1. initially there are two notifiers with ranges > > 0-0xfedfffff, 0xfef00000-0xffffffffffffffff, > > IOVAs from 0x3c000000 - 0x3c1fffff is in shadow page table. > > > > 2. in vfio, memory_region_register_iommu_notifier() is followed by > > memory_region_iommu_replay(), which will first call address space > > unmap, > > and walk and add back all entries in vtd shadow page table. e.g. > > (1) for notifier 0-0xfedfffff, > > IOVAs from 0 - 0xffffffff get unmapped, > > and IOVAs from 0x3c000000 - 0x3c1fffff get mapped > > (2) for notifier 0xfef00000-0xffffffffffffffff > > IOVAs from 0 - 0x7fffffffff get unmapped, > > but IOVAs from 0x3c000000 - 0x3c1fffff cannot get mapped back. > > > > Cc: Auger Eric > > Signed-off-by: Yan Zhao > > > > --- > > v3: > > refined code style and message format > > > > v2: > > 1. added a local variable entry_end (Auger Eric) > > 2. using PRIx64 as format for address range in warning message > > (Auger Eric) > > --- > > memory.c | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/memory.c b/memory.c > > index 0a089a7..c7154ab 100644 > > --- a/memory.c > > +++ b/memory.c > > @@ -1937,13 +1937,13 @@ void memory_region_notify_one(IOMMUNotifier *notifier, > > IOMMUTLBEntry *entry) > > { > > IOMMUNotifierFlag request_flags; > > + hwaddr entry_end = entry->iova + entry->addr_mask; > > > > /* > > * Skip the notification if the notification does not overlap > > * with registered range. > > */ > > - if (notifier->start > entry->iova + entry->addr_mask || > > - notifier->end < entry->iova) { > > + if (notifier->start > entry_end || notifier->end < entry->iova) { > > return; > > } > > > > @@ -1953,6 +1953,15 @@ void memory_region_notify_one(IOMMUNotifier *notifier, > > request_flags = IOMMU_NOTIFIER_UNMAP; > > } > > > > + if (entry->iova < notifier->start || entry_end > notifier->end) { > > + warn_report("%s IOMMUTLBEntry 0x%" PRIx64 " - 0x%" PRIx64 > > + " outside of notifier scope 0x%" PRIx64 " - 0x%" PRIx64, > > + (request_flags == IOMMU_NOTIFIER_MAP) ? > > + "Mapping" : "Unmapping", > > + entry->iova, entry->iova + entry->addr_mask, > entry_end as well. > > Then shouldn't we assert in that case? > Yes, assert is good. I'll change warning to assert then. Thanks Yan > Thanks > > Eric > > + notifier->start, notifier->end); > > + } > > + > > if (notifier->notifier_flags & request_flags) { > > notifier->notify(notifier, entry); > > } > >