From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A63B8C48BD5 for ; Tue, 25 Jun 2019 13:42:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D2D12133F for ; Tue, 25 Jun 2019 13:42:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D2D12133F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfli7-00016P-Nx for qemu-devel@archiver.kernel.org; Tue, 25 Jun 2019 09:42:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58365) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hflaX-0003H3-PO for qemu-devel@nongnu.org; Tue, 25 Jun 2019 09:34:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hflaU-0001Jo-Or for qemu-devel@nongnu.org; Tue, 25 Jun 2019 09:34:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42780) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hflaQ-0001Gg-W4; Tue, 25 Jun 2019 09:34:15 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7EA563086227; Tue, 25 Jun 2019 13:34:08 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 141E06085B; Tue, 25 Jun 2019 13:34:01 +0000 (UTC) Date: Tue, 25 Jun 2019 15:33:57 +0200 From: Igor Mammedov To: gengdongjiu Message-ID: <20190625153357.05020884@redhat.com> In-Reply-To: <623d8454-6d9a-43ff-dd34-f5e0d1896f01@huawei.com> References: <1557832703-42620-1-git-send-email-gengdongjiu@huawei.com> <1557832703-42620-3-git-send-email-gengdongjiu@huawei.com> <20190620141052.370788fb@redhat.com> <20190620170934.39eae310@redhat.com> <20190624131629.7f586861@redhat.com> <623d8454-6d9a-43ff-dd34-f5e0d1896f01@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 25 Jun 2019 13:34:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, linuxarm@huawei.com, shannon.zhaosl@gmail.com, zhengxiang9@huawei.com, qemu-arm@nongnu.org, james.morse@arm.com, xuwei5@huawei.com, jonathan.cameron@huawei.com, pbonzini@redhat.com, lersek@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 25 Jun 2019 17:56:00 +0800 gengdongjiu wrote: > On 2019/6/24 19:16, Igor Mammedov wrote: > >>>> On 2019/6/20 20:10, Igor Mammedov wrote: > >>>>>> + */ > >>>>>> +struct AcpiGenericErrorStatus { > >>>>>> + /* It is a bitmask composed of ACPI_GEBS_xxx macros */ > >>>>>> + uint32_t block_status; > >>>>>> + uint32_t raw_data_offset; > >>>>>> + uint32_t raw_data_length; > >>>>>> + uint32_t data_length; > >>>>>> + uint32_t error_severity; > >>>>>> +} QEMU_PACKED; > >>>>>> +typedef struct AcpiGenericErrorStatus AcpiGenericErrorStatus; > >>>>> there shouldn't be packed structures, > >>>>> is it a leftover from previous version? > >>>> I remember some people suggest to add QEMU_PACKED before, anyway I will remove it in my next version patch. > >>> Question is why it's there and where it is used? > >> sorry, it is my carelessness. it should be packed structures. > >> > >> I used this structures to get its actual total size and member offset in [PATCH v17 10/10]. > >> If it is not packed structures, the total size and member offset may be not right. > > I'd suggest to drop these typedefs and use a macro with size for that purpose, > > Also it might be good to make it local to the file that would use it. > so you mean we also use macro for the member offset in the structures? such as the offset of data_length, yes, but I hope there won't be need for data_length offset at all. > may be there is many hardcode. > > > > >>> BTW: > >>> series doesn't apply to master anymore. >