From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC0FC48BD5 for ; Tue, 25 Jun 2019 13:47:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93AE12133F for ; Tue, 25 Jun 2019 13:47:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93AE12133F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hflna-0005RD-PT for qemu-devel@archiver.kernel.org; Tue, 25 Jun 2019 09:47:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60483) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hflhV-0000hi-CH for qemu-devel@nongnu.org; Tue, 25 Jun 2019 09:41:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hflhT-0006Zp-Qm for qemu-devel@nongnu.org; Tue, 25 Jun 2019 09:41:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48154) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hflhQ-0006Um-9H; Tue, 25 Jun 2019 09:41:28 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA5483001822; Tue, 25 Jun 2019 13:41:16 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78CCF5C22F; Tue, 25 Jun 2019 13:41:09 +0000 (UTC) Date: Tue, 25 Jun 2019 15:41:05 +0200 From: Igor Mammedov To: gengdongjiu Message-ID: <20190625154105.11e5ae8d@redhat.com> In-Reply-To: <93dcd75e-77e4-8813-beef-7939cdb75413@huawei.com> References: <1557832703-42620-1-git-send-email-gengdongjiu@huawei.com> <1557832703-42620-6-git-send-email-gengdongjiu@huawei.com> <20190620144257.7400b0a7@redhat.com> <93dcd75e-77e4-8813-beef-7939cdb75413@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 25 Jun 2019 13:41:20 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v17 05/10] acpi: add build_append_ghes_generic_status() helper for Generic Error Status Block X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, linuxarm@huawei.com, shannon.zhaosl@gmail.com, zhengxiang9@huawei.com, qemu-arm@nongnu.org, james.morse@arm.com, xuwei5@huawei.com, jonathan.cameron@huawei.com, pbonzini@redhat.com, lersek@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 25 Jun 2019 20:11:11 +0800 gengdongjiu wrote: > On 2019/6/20 20:42, Igor Mammedov wrote: > > On Tue, 14 May 2019 04:18:18 -0700 > > Dongjiu Geng wrote: > > > >> It will help to add Generic Error Status Block to ACPI tables > >> without using packed C structures and avoid endianness > >> issues as API doesn't need explicit conversion. > >> > >> Signed-off-by: Dongjiu Geng > >> --- > >> hw/acpi/aml-build.c | 14 ++++++++++++++ > >> include/hw/acpi/aml-build.h | 6 ++++++ > >> 2 files changed, 20 insertions(+) > >> > >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > >> index 102a288..ce90970 100644 > >> --- a/hw/acpi/aml-build.c > >> +++ b/hw/acpi/aml-build.c > >> @@ -296,6 +296,20 @@ void build_append_ghes_notify(GArray *table, const uint8_t type, > >> build_append_int_noprefix(table, error_threshold_window, 4); > >> } > >> > >> +/* Generic Error Status Block > >> + * ACPI 4.0: 17.3.2.6.1 Generic Error Data > >> + */ > >> +void build_append_ghes_generic_status(GArray *table, uint32_t block_status, > > maybe ..._generic_error_status??? > good point, the build_append_ghes_generic_error_status() is better than build_append_ghes_generic_status() > > > > >> + uint32_t raw_data_offset, uint32_t raw_data_length, > >> + uint32_t data_length, uint32_t error_severity) > > see CODING_STYLE, 1.1 Multiline Indent > > > >> +{ > > when describing filds from spec try to add 'verbatim' copy of the name from spec > > so it would be esy to grep for it. Like: > > /* Block Status */ > >> + build_append_int_noprefix(table, block_status, 4); > > /* Raw Data Offset */ > > > > note applies all other places where you compose ACPI tables > ok > > > > >> + build_append_int_noprefix(table, raw_data_offset, 4); > >> + build_append_int_noprefix(table, raw_data_length, 4); > >> + build_append_int_noprefix(table, data_length, 4); > >> + build_append_int_noprefix(table, error_severity, 4); > >> +} > >> + > >> /* Generic Error Data Entry > >> * ACPI 4.0: 17.3.2.6.1 Generic Error Data > >> */ > >> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > >> index a71db2f..1ec7e1b 100644 > >> --- a/include/hw/acpi/aml-build.h > >> +++ b/include/hw/acpi/aml-build.h > >> @@ -425,6 +425,12 @@ void build_append_ghes_generic_data(GArray *table, const char *section_type, > >> uint32_t error_data_length, uint8_t *fru_id, > >> uint8_t *fru_text, uint64_t time_stamp); > >> > >> +void > >> +build_append_ghes_generic_status(GArray *table, uint32_t block_status, > >> + uint32_t raw_data_offset, > >> + uint32_t raw_data_length, > >> + uint32_t data_length, uint32_t error_severity); > > this and previous patch, it might be better to to move declaration > > to its own header, for example to include/hw/acpi/acpi_ghes.h > > that you are adding later in the series. > > And maybe move helpers to hw/acpi/acpi_ghes.c > > They are not really independent ACPI primitives that are shared > > with other tables, aren't they? > Some ACPI primitives are shared with other table, such as Notification Structure. > we have 10 types of error sources, some error source will share the Notification Structure primitives. If read spec right, "Notification Structure" is a sub-table of HEST mechanism so it should be fine to put all this together in hw/acpi/acpi_ghes.c. > Now I only implement Generic Hardware Error Source version 2 (GHESv2 - Type 10) > > > . > >> + > >> void build_srat_memory(AcpiSratMemoryAffinity *numamem, uint64_t base, > >> uint64_t len, int node, MemoryAffinityFlags flags); > >> > > > > . > > >