From: Eduardo Habkost <ehabkost@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Jiri Denemark <jdenemar@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models
Date: Tue, 25 Jun 2019 14:59:56 -0300 [thread overview]
Message-ID: <20190625175956.GT1862@habkost.net> (raw)
In-Reply-To: <20190625162603.GK3139@redhat.com>
On Tue, Jun 25, 2019 at 05:26:03PM +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 25, 2019 at 02:00:06AM -0300, Eduardo Habkost wrote:
> > Base code for versioned CPU models. This will register a "-4.1"
> > version of all existing CPU models, and make the unversioned CPU
> > models be an alias for the -4.1 versions on the pc-*-4.1 machine
> > types.
> >
> > On older machine types, the unversioned CPU models will keep the
> > old behavior. This way, management software can use old machine
> > types while resolving aliases if compatibility with older QEMU
> > versions is required.
> >
> > Using "-machine none", the unversioned CPU models will be aliases
> > to the latest CPU model version.
> >
> > Includes a test case to ensure that:
> > old machine types won't report any alias to versioned CPU models;
> > "pc-*-4.1" will return aliases to -4.1 CPU models;
> > and "-machine none" will report aliases to some versioned CPU model.
>
> I'm wondering about the of tieing CPU versions to the release version
> number and whether its a good idea or not ?
>
> Could there be a reason for us to introduce 2 or more variants
> of a CPU in the same release & would that be a problem if we needed
> todo it ?
I don't see a problem, we can use 3-digit versions that won't be
enabled by any machine type by default.
>
> Consider if we did not have a Broadwell CPU model defined yet
> and we were adding it at the same time as Spectre came out. We
> might have needed to add "Broadwell-NN" and "Broadwell-MM" one
> with "spec-ctrl" and one without, in order to ensure runability
> on hosts with & without the microcode upgrade. "Broadwell" alias
> would resolve to either the NN or MM variant according to what
> the current host supported.
>
> One way to cope with that would have been to add a 3rd digit
> after the version number. eg a Broadwell-4.1.1 and Broadwell-4.1.2
That's exactly what I did for Cascadelake-Server, see patch 6/6.
>
> An alternative could consider using a plain counter for the CPU
> versions eg Broadwell-1, Broadwell-2, etc.... ?
This is possible too. It would require a more complex mapping
between machine types and CPU model versions, though. Maybe this
is worth the extra complexity because it would make the external
interfaces simpler.
>
>
> If we want to backport the newly added CPU model variants to
> exist branches, plain counters don't have the unsightly mismatch.
> eg we'd backport Broadwell-3 to QEMU 3.1, not Broadwell-4.1 to
> QEMU 3.1. This isn't a functional problem, just something looking
> a bit odd.
I think I'm liking this approach. If we're untying CPU models
from machine types, let's do it all the way.
--
Eduardo
next prev parent reply other threads:[~2019-06-25 18:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 5:00 [Qemu-devel] [PATCH 0/6] x86 CPU model versioning Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 1/6] i386: Add x-force-features option for testing Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 2/6] i386: Remove unused host_cpudef variable Eduardo Habkost
2019-06-25 9:04 ` Dr. David Alan Gilbert
2019-06-25 5:00 ` [Qemu-devel] [PATCH 3/6] qmp: Add "alias-of" field to query-cpu-definitions Eduardo Habkost
2019-06-25 16:15 ` Daniel P. Berrangé
2019-06-25 18:00 ` Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models Eduardo Habkost
2019-06-25 9:32 ` Dr. David Alan Gilbert
2019-06-25 13:40 ` Eduardo Habkost
2019-06-25 14:32 ` Dr. David Alan Gilbert
2019-06-25 14:53 ` Eduardo Habkost
2019-06-25 14:56 ` Dr. David Alan Gilbert
2019-06-25 16:05 ` Eduardo Habkost
2019-06-25 16:26 ` Daniel P. Berrangé
2019-06-25 17:59 ` Eduardo Habkost [this message]
2019-06-25 18:08 ` Daniel P. Berrangé
2019-06-25 18:11 ` Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 5/6] docs: Deprecate CPU model runnability guarantees Eduardo Habkost
2019-06-25 5:00 ` [Qemu-devel] [PATCH 6/6] i386: Add Cascadelake-Server-4.1.1 CPU model Eduardo Habkost
2019-06-25 5:35 ` Tao Xu
2019-06-25 13:11 ` Eduardo Habkost
2019-06-25 5:15 ` [Qemu-devel] [PATCH 0/6] x86 CPU model versioning no-reply
2019-06-25 16:13 ` Daniel P. Berrangé
2019-06-25 18:11 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625175956.GT1862@habkost.net \
--to=ehabkost@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).