Re: [Qemu-devel] [PATCH for-4.1 2/2] s390x/tcg: move fallthrough annotation

From: Cornelia Huck <cohuck@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Collin Walling <walling@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Stefan Weil <sw@weilnetz.de>,
	qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH for-4.1 2/2] s390x/tcg: move fallthrough annotation
Date: Tue, 16 Jul 2019 17:26:26 +0200	[thread overview]
Message-ID: <20190716172626.7abc7736.cohuck@redhat.com> (raw)
In-Reply-To: <cfce6fc7-8459-7c04-0b57-500f3d143931@redhat.com>

On Tue, 16 Jul 2019 17:22:59 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> On 7/8/19 2:54 PM, Cornelia Huck wrote:
> > ...so that the compiler properly recognizes it.
> > 
> > Reported-by: Stefan Weil <sw@weilnetz.de>
> > Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO")
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> >  target/s390x/translate_vx.inc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_vx.inc.c
> > index 7b1d31cba5cf..41d5cf869f94 100644
> > --- a/target/s390x/translate_vx.inc.c
> > +++ b/target/s390x/translate_vx.inc.c
> > @@ -577,8 +577,8 @@ static DisasJumpType op_vllez(DisasContext *s, DisasOps *o)
> >              enr = 0;
> >              break;
> >          }
> > -    default:
> >          /* fallthrough */
> > +    default:  
> 
> Haha :)
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks, but this is already merged :)

> 
> >          gen_program_exception(s, PGM_SPECIFICATION);
> >          return DISAS_NORETURN;
> >      }
> >