From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0490C76186 for ; Wed, 17 Jul 2019 10:41:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD41D2173B for ; Wed, 17 Jul 2019 10:41:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD41D2173B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnhNg-0000UN-0Z for qemu-devel@archiver.kernel.org; Wed, 17 Jul 2019 06:41:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57589) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnhNU-0008Oc-SI for qemu-devel@nongnu.org; Wed, 17 Jul 2019 06:41:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnhNT-0005OP-Qk for qemu-devel@nongnu.org; Wed, 17 Jul 2019 06:41:40 -0400 Received: from 6.mo68.mail-out.ovh.net ([46.105.63.100]:47937) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnhNT-0005NM-Ik for qemu-devel@nongnu.org; Wed, 17 Jul 2019 06:41:39 -0400 Received: from player714.ha.ovh.net (unknown [10.109.146.240]) by mo68.mail-out.ovh.net (Postfix) with ESMTP id 30EA713C7D7 for ; Wed, 17 Jul 2019 12:41:37 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player714.ha.ovh.net (Postfix) with ESMTPSA id 33EA77F51E3C; Wed, 17 Jul 2019 10:41:32 +0000 (UTC) Date: Wed, 17 Jul 2019 12:41:31 +0200 From: Greg Kurz To: Shivaprasad G Bhat Message-ID: <20190717124131.02857a72@bahia.lab.toulouse-stg.fr.ibm.com> In-Reply-To: <156335156198.82682.8756968724044750843.stgit@lep8c.aus.stglabs.ibm.com> References: <156335150620.82682.9535735857478533420.stgit@lep8c.aus.stglabs.ibm.com> <156335156198.82682.8756968724044750843.stgit@lep8c.aus.stglabs.ibm.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 18113477701493758293 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrieefgddtjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.63.100 Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/4] ppc: fix memory leak in spapr_caps_add_properties X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 17 Jul 2019 03:19:43 -0500 Shivaprasad G Bhat wrote: > Free the capability name string after setting > the capability. > > Signed-off-by: Shivaprasad G Bhat > --- Reviewed-by: Greg Kurz > hw/ppc/spapr_caps.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c > index bbb001f84a..0263c78d69 100644 > --- a/hw/ppc/spapr_caps.c > +++ b/hw/ppc/spapr_caps.c > @@ -778,7 +778,7 @@ void spapr_caps_add_properties(SpaprMachineClass *smc, Error **errp) > > for (i = 0; i < ARRAY_SIZE(capability_table); i++) { > SpaprCapabilityInfo *cap = &capability_table[i]; > - const char *name = g_strdup_printf("cap-%s", cap->name); > + char *name = g_strdup_printf("cap-%s", cap->name); > char *desc; > > object_class_property_add(klass, name, cap->type, > @@ -786,11 +786,13 @@ void spapr_caps_add_properties(SpaprMachineClass *smc, Error **errp) > NULL, cap, &local_err); > if (local_err) { > error_propagate(errp, local_err); > + g_free(name); > return; > } > > desc = g_strdup_printf("%s", cap->description); > object_class_property_set_description(klass, name, desc, &local_err); > + g_free(name); > g_free(desc); > if (local_err) { > error_propagate(errp, local_err); > >