From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAEAC7618F for ; Fri, 19 Jul 2019 15:48:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11DD921872 for ; Fri, 19 Jul 2019 15:48:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11DD921872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoV7t-0003gq-Cs for qemu-devel@archiver.kernel.org; Fri, 19 Jul 2019 11:48:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35659) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoV7Q-0003H7-NV for qemu-devel@nongnu.org; Fri, 19 Jul 2019 11:48:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoV7A-0006IR-49 for qemu-devel@nongnu.org; Fri, 19 Jul 2019 11:48:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45928) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hoV6f-0004g3-Ig; Fri, 19 Jul 2019 11:47:40 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E1AB53082AEF; Fri, 19 Jul 2019 15:45:00 +0000 (UTC) Received: from redhat.com (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 06C015C234; Fri, 19 Jul 2019 15:44:47 +0000 (UTC) Date: Fri, 19 Jul 2019 16:44:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Stefan Hajnoczi Message-ID: <20190719154444.GF4057@redhat.com> References: <20190719133530.28688-1-mehta.aaru20@gmail.com> <20190719133530.28688-12-mehta.aaru20@gmail.com> <20190719154115.GG24412@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190719154115.GG24412@stefanha-x1.localdomain> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 19 Jul 2019 15:45:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v6 11/14] qemu-io: adds option to use aio engine X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Fam Zheng , Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Sergio Lopez , Markus Armbruster , qemu-devel@nongnu.org, Maxim Levitsky , saket.sinha89@gmail.com, Paolo Bonzini , Max Reitz , Julia Suvorova , Aarushi Mehta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 19, 2019 at 04:41:15PM +0100, Stefan Hajnoczi wrote: > On Fri, Jul 19, 2019 at 07:05:27PM +0530, Aarushi Mehta wrote: > > Use -i AIOMODE instead of -k. > > > > Signed-off-by: Aarushi Mehta > > --- > > qemu-io.c | 25 ++++++++++++++++--------- > > 1 file changed, 16 insertions(+), 9 deletions(-) > > > > diff --git a/qemu-io.c b/qemu-io.c > > index f64eca6940..3cee06248e 100644 > > --- a/qemu-io.c > > +++ b/qemu-io.c > > @@ -130,7 +130,7 @@ static void open_help(void) > > " -C, -- use copy-on-read\n" > > " -n, -- disable host cache, short for -t none\n" > > " -U, -- force shared permissions\n" > > -" -k, -- use kernel AIO implementation (on Linux only)\n" > > +" -i, -- use AIO mode (threads, native or io_uring)" > > Please keep the existing option for backwards compatibility. Existing > command-lines must continue to work so we don't inconvenience users. We could deprecate the -k option though, so it can be deleted a couple of releases later. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|