From: Wei Yang <richard.weiyang@gmail.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: quintela@redhat.com, Wei Yang <richardw.yang@linux.intel.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] migration/savevm: flush file for iterable_only case
Date: Sat, 20 Jul 2019 01:38:47 +0000 [thread overview]
Message-ID: <20190720013847.svmol4mlfosf3oy3@master> (raw)
In-Reply-To: <20190719164759.GF3000@work-vm>
On Fri, Jul 19, 2019 at 05:47:59PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (richardw.yang@linux.intel.com) wrote:
>> It would be proper to flush file even for iterable_only case.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>
>OK, I don't think this is actually necessary; but it's safe.
>We only really need the flush at the end of the file, and in the
>non-iterable-only case it's not the end of the file.
>
>Since it makes your next change simpler,
Yep, you are so kind.
>
>Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
>> ---
>> migration/savevm.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/migration/savevm.c b/migration/savevm.c
>> index c0e557b4c2..becedcc1c6 100644
>> --- a/migration/savevm.c
>> +++ b/migration/savevm.c
>> @@ -1292,7 +1292,7 @@ int qemu_savevm_state_complete_precopy(QEMUFile *f, bool iterable_only,
>> }
>>
>> if (iterable_only) {
>> - return 0;
>> + goto flush;
>> }
>>
>> vmdesc = qjson_new();
>> @@ -1353,6 +1353,7 @@ int qemu_savevm_state_complete_precopy(QEMUFile *f, bool iterable_only,
>> }
>> qjson_destroy(vmdesc);
>>
>> +flush:
>> qemu_fflush(f);
>> return 0;
>> }
>> --
>> 2.17.1
>>
>--
>Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-07-20 1:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 14:09 [Qemu-devel] [PATCH 0/3] migration/savevm: move non SaveStateEntry condition check out of iteration Wei Yang
2019-07-09 14:09 ` [Qemu-devel] [PATCH 1/3] migration/savevm: flush file for iterable_only case Wei Yang
2019-07-19 16:47 ` Dr. David Alan Gilbert
2019-07-20 1:38 ` Wei Yang [this message]
2019-07-09 14:09 ` [Qemu-devel] [PATCH 2/3] migration/savevm: split qemu_savevm_state_complete_precopy() into two parts Wei Yang
2019-07-19 16:49 ` Dr. David Alan Gilbert
2019-07-09 14:09 ` [Qemu-devel] [PATCH 3/3] migration/savevm: move non SaveStateEntry condition check out of iteration Wei Yang
2019-07-19 16:59 ` Dr. David Alan Gilbert
2019-07-20 1:40 ` Wei Yang
2019-08-07 17:31 ` [Qemu-devel] [PATCH 0/3] " Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720013847.svmol4mlfosf3oy3@master \
--to=richard.weiyang@gmail.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).