From: Corey Minyard <minyard@acm.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Laurent Vivier <laurent@vivier.eu>,
qemu-block@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Max Reitz <mreitz@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH-for-4.1? 4/7] hw/ipmi: Rewrite a fall through comment
Date: Sat, 20 Jul 2019 21:10:16 -0500 [thread overview]
Message-ID: <20190721021016.GG3066@minyard.net> (raw)
In-Reply-To: <20190719131425.10835-5-philmd@redhat.com>
On Fri, Jul 19, 2019 at 03:14:22PM +0200, Philippe Mathieu-Daudé wrote:
> GCC9 is confused by this comment when building with CFLAG
> -Wimplicit-fallthrough=2:
>
> hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’:
> hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
> 178 | ch |= 0x10;
> | ~~~^~~~~~~
> hw/ipmi/ipmi_bmc_extern.c:181:5: note: here
> 181 | default:
> | ^~~~~~~
> cc1: all warnings being treated as errors
> make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1
>
> Rewrite the comment using 'fall through' which is recognized by
> GCC and static analyzers.
>
> Reported-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/ipmi/ipmi_bmc_extern.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index c0a8dac346..d4cbd210c4 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -176,8 +176,7 @@ static void addchar(IPMIBmcExtern *ibe, unsigned char ch)
> ibe->outbuf[ibe->outlen] = VM_ESCAPE_CHAR;
> ibe->outlen++;
> ch |= 0x10;
> - /* No break */
> -
> + /* fall through */
> default:
> ibe->outbuf[ibe->outlen] = ch;
> ibe->outlen++;
> --
> 2.20.1
>
Well, whatever, this is fine.
Acked-by: Corey Minyard <cminyard@mvista.com>
next prev parent reply other threads:[~2019-07-21 2:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 13:14 [Qemu-devel] [PATCH-for-4.1? 0/7] Trivial switch 'fall through' comment fixes for GCC9 Philippe Mathieu-Daudé
2019-07-19 13:14 ` [Qemu-devel] [PATCH-for-4.1? 1/7] json: Move switch 'fall through' comment to correct place Philippe Mathieu-Daudé
2019-07-19 15:31 ` Eric Blake
2019-08-21 8:54 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-07-19 13:14 ` [Qemu-devel] [PATCH-for-4.1? 2/7] hw/dma/omap_dma: " Philippe Mathieu-Daudé
2019-07-19 13:27 ` Peter Maydell
2019-08-21 8:55 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-07-19 13:14 ` [Qemu-devel] [PATCH-for-4.1 3/7] hw/block/pflash_cfi02: Rewrite a fall through comment Philippe Mathieu-Daudé
2019-07-19 13:27 ` Peter Maydell
2019-07-22 11:43 ` Philippe Mathieu-Daudé
2019-07-25 0:27 ` [Qemu-devel] [Qemu-block] " John Snow
2019-07-25 10:59 ` Philippe Mathieu-Daudé
2019-07-19 13:14 ` [Qemu-devel] [PATCH-for-4.1? 4/7] hw/ipmi: " Philippe Mathieu-Daudé
2019-07-21 2:10 ` Corey Minyard [this message]
2019-08-21 8:56 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-07-19 13:14 ` [Qemu-devel] [PATCH-for-4.1? 5/7] target/ppc: " Philippe Mathieu-Daudé
2019-07-19 14:20 ` David Gibson
2019-08-21 8:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-07-19 13:14 ` [Qemu-devel] [PATCH-for-4.1? 6/7] vl: " Philippe Mathieu-Daudé
2019-07-25 0:28 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-21 8:58 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-07-19 13:14 ` [Qemu-devel] [PATCH-for-4.1? 7/7] spapr_events: " Philippe Mathieu-Daudé
2019-07-19 14:20 ` David Gibson
2019-08-21 8:59 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721021016.GG3066@minyard.net \
--to=minyard@acm.org \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).