From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78760C7618B for ; Tue, 23 Jul 2019 15:24:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EBF4223A0 for ; Tue, 23 Jul 2019 15:24:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EBF4223A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpweG-0006CN-Ba for qemu-devel@archiver.kernel.org; Tue, 23 Jul 2019 11:24:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45183) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpwe4-0005ZY-K5 for qemu-devel@nongnu.org; Tue, 23 Jul 2019 11:24:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpwe3-0005QQ-Dx for qemu-devel@nongnu.org; Tue, 23 Jul 2019 11:24:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34288) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpwe3-0005Oy-8b for qemu-devel@nongnu.org; Tue, 23 Jul 2019 11:24:03 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E4ADC057F2C; Tue, 23 Jul 2019 15:24:02 +0000 (UTC) Received: from localhost (ovpn-116-40.gru2.redhat.com [10.97.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 916AA5D72E; Tue, 23 Jul 2019 15:23:59 +0000 (UTC) Date: Tue, 23 Jul 2019 12:23:57 -0300 From: Eduardo Habkost To: Igor Mammedov Message-ID: <20190723152357.GI11469@habkost.net> References: <20190716145121.19578-1-tao3.xu@intel.com> <20190716145121.19578-3-tao3.xu@intel.com> <20190723165641.55930926@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723165641.55930926@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 Jul 2019 15:24:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v7 02/11] numa: move numa global variable nb_numa_nodes into MachineState X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jingqi.liu@intel.com, Tao Xu , fan.du@intel.com, qemu-devel@nongnu.org, jonathan.cameron@huawei.com, dan.j.williams@intel.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 23, 2019 at 04:56:41PM +0200, Igor Mammedov wrote: > On Tue, 16 Jul 2019 22:51:12 +0800 > Tao Xu wrote: > > > Add struct NumaState in MachineState and move existing numa global > > nb_numa_nodes(renamed as "num_nodes") into NumaState. And add variable > > numa_support into MachineClass to decide which submachines support NUMA. > > > > Suggested-by: Igor Mammedov > > Suggested-by: Eduardo Habkost > > Signed-off-by: Tao Xu > > --- > > > > No changes in v7. > > > > Changes in v6: > > - Rebase to upstream, move globals in arm/sbsa-ref and use > > numa_mem_supported > > - When used once or twice in the function, use > > ms->numa_state->num_nodes directly > > - Correct some mistakes > > - Use once monitor_printf in hmp_info_numa > > --- [...] > > if (pxb->numa_node != NUMA_NODE_UNASSIGNED && > > - pxb->numa_node >= nb_numa_nodes) { > > + pxb->numa_node >= ms->numa_state->num_nodes) { > this will crash if user tries to use device on machine that doesn't support numa > check that numa_state is not NULL before dereferencing That's exactly why the machine_num_numa_nodes() was created in v5, but then you asked for its removal. -- Eduardo