From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, david@redhat.com,
Wei Yang <richardw.yang@linux.intel.com>,
mst@redhat.com
Subject: [Qemu-devel] [PATCH v2 1/2] memory-device: not necessary to use goto for the last check
Date: Tue, 30 Jul 2019 08:37:39 +0800 [thread overview]
Message-ID: <20190730003740.20694-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190730003740.20694-1-richardw.yang@linux.intel.com>
We are already at the last condition check.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
hw/mem/memory-device.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 5f2c408036..df3261b32a 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -186,7 +186,6 @@ static uint64_t memory_device_get_free_addr(MachineState *ms,
if (!range_contains_range(&as, &new)) {
error_setg(errp, "could not find position in guest address space for "
"memory device - memory fragmented due to alignments");
- goto out;
}
out:
g_slist_free(list);
--
2.17.1
next prev parent reply other threads:[~2019-07-30 0:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 0:37 [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr Wei Yang
2019-07-30 0:37 ` Wei Yang [this message]
2019-08-08 1:42 ` [Qemu-devel] [PATCH v2 1/2] memory-device: not necessary to use goto for the last check Zeng, Star
2019-08-08 2:13 ` Wei Yang
2019-08-08 2:30 ` Zeng, Star
2019-08-08 2:38 ` Wei Yang
2019-08-08 7:06 ` David Hildenbrand
2019-08-19 2:38 ` Wei Yang
2019-08-19 5:32 ` Zeng, Star
2019-08-19 6:36 ` Wei Yang
2019-07-30 0:37 ` [Qemu-devel] [PATCH v2 2/2] memory-device: break the loop if tmp exceed the hinted range Wei Yang
2019-07-30 7:38 ` David Hildenbrand
2019-07-30 9:30 ` Igor Mammedov
2019-09-13 23:47 ` [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr Wei Yang
2019-09-14 19:40 ` Michael S. Tsirkin
2019-10-12 9:02 ` Wei Yang
2019-10-14 15:05 ` Eduardo Habkost
2019-10-14 22:00 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730003740.20694-2-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).