From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com,
armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
stefanha@redhat.com, den@openvz.org, jsnow@redhat.com
Subject: [Qemu-devel] [PATCH 5/8] block/backup: fix backup_cow_with_offload for last cluster
Date: Wed, 7 Aug 2019 11:07:47 +0300 [thread overview]
Message-ID: <20190807080750.15950-6-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20190807080750.15950-1-vsementsov@virtuozzo.com>
We shouldn't try to copy bytes beyond EOF. Fix it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block/backup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/backup.c b/block/backup.c
index a4d37d2d62..eb41e4af4f 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -155,7 +155,7 @@ static int coroutine_fn backup_cow_with_offload(BackupBlockJob *job,
int ret;
int nr_clusters;
BlockBackend *blk = job->common.blk;
- int nbytes = end - start;
+ int nbytes = MIN(end - start, job->len - start);
int read_flags = is_write_notifier ? BDRV_REQ_NO_SERIALISING : 0;
assert(end - start < INT_MAX);
--
2.18.0
next prev parent reply other threads:[~2019-08-07 8:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 8:07 [Qemu-devel] [PATCH 0/8] backup improvements Vladimir Sementsov-Ogievskiy
2019-08-07 8:07 ` [Qemu-devel] [PATCH 1/8] block/backup: deal with zero detection Vladimir Sementsov-Ogievskiy
2019-08-07 8:07 ` [Qemu-devel] [PATCH 2/8] block/backup: refactor write_flags Vladimir Sementsov-Ogievskiy
2019-08-07 16:53 ` Max Reitz
2019-08-07 8:07 ` [Qemu-devel] [PATCH 3/8] block/io: handle alignment and max_transfer for copy_range Vladimir Sementsov-Ogievskiy
2019-08-07 17:28 ` Max Reitz
2019-08-09 7:50 ` Vladimir Sementsov-Ogievskiy
2019-08-07 8:07 ` [Qemu-devel] [PATCH 4/8] block/backup: improve unallocated clusters skipping Vladimir Sementsov-Ogievskiy
2019-08-07 18:01 ` Max Reitz
2019-08-09 7:50 ` Vladimir Sementsov-Ogievskiy
2019-08-09 9:12 ` Vladimir Sementsov-Ogievskiy
2019-08-09 10:25 ` Vladimir Sementsov-Ogievskiy
2019-08-09 10:10 ` Vladimir Sementsov-Ogievskiy
2019-08-09 12:25 ` Max Reitz
2019-08-09 12:47 ` Vladimir Sementsov-Ogievskiy
2019-08-09 12:53 ` Max Reitz
2019-08-07 8:07 ` Vladimir Sementsov-Ogievskiy [this message]
2019-08-07 18:05 ` [Qemu-devel] [PATCH 5/8] block/backup: fix backup_cow_with_offload for last cluster Max Reitz
2019-08-07 8:07 ` [Qemu-devel] [PATCH 6/8] block/backup: teach backup_cow_with_bounce_buffer to copy more at once Vladimir Sementsov-Ogievskiy
2019-08-07 18:25 ` Max Reitz
2019-08-07 8:07 ` [Qemu-devel] [PATCH 7/8] block/backup: merge duplicated logic into backup_do_cow Vladimir Sementsov-Ogievskiy
2019-08-07 18:37 ` Max Reitz
2019-08-07 8:07 ` [Qemu-devel] [PATCH 8/8] block/backup: backup_do_cow: use bdrv_dirty_bitmap_next_dirty_area Vladimir Sementsov-Ogievskiy
2019-08-07 18:46 ` Max Reitz
2019-08-09 7:54 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807080750.15950-6-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).