qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Black <daniel@linux.ibm.com>
To: Tao Xu <tao3.xu@intel.com>, jingqi.liu@intel.com
Cc: ehabkost@redhat.com, fan.du@intel.com, qemu-devel@nongnu.org,
	jonathan.cameron@huawei.com, imammedo@redhat.com,
	dan.j.williams@intel.com
Subject: Re: [Qemu-devel] [PATCH RESEND v8 09/11] numa: Extend the CLI to provide memory latency and bandwidth information
Date: Wed, 7 Aug 2019 09:14:49 +1000	[thread overview]
Message-ID: <20190807091449.2e88b175@volution.ozlabs.ibm.com> (raw)
In-Reply-To: <20190731011209.22538-10-tao3.xu@intel.com>


Liu Jingqi, Tao Xu,

Apologies to the late response on a patch on what is already a v8 patch.

The specification of latency and bandwidth is very much following the
ACPI specification.

For a qemu interface I think this should be in more human measurements
(time for latency and a bandwidth rate for the bandwidth).

e.g rather than
 -object memory-backend-ram,size=64M,id=m0
 -object memory-backend-ram,size=64M,id=m1geosync
 -numa node,nodeid=0,memdev=m0
 -numa node,nodeid=1,memdev=m1geosync,initiator=0
 -numa cpu,node-id=0,socket-id=0
 -numa cpu,node-id=0,socket-id=1
 -numa
hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-latency,base-lat=1000,latency=5
 -numa
hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-bandwidth,base-bw=20,bandwidth=5
 -numa
hmat-lb,initiator=0,target=1,hierarchy=memory,data-type=access-latency,base-lat=100,latency=10
 -numa
 hmat-lb,initiator=0,target=1,hierarchy=memory,data-type=access-bandwidth,base-bw=20,bandwidth=10


Suggest a form like:

 -numa
hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-latency,latency=NUM[fpnm[s]]
 -numa
hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-bandwidth,bandwidth=NUM[KMGP][Bb[ps]]

So:

 -numa
hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-latency,latency=5ns
 -numa
hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-bandwidth,bandwidth=5Gb


So this would remove the base-[lt,bw] settings and compute those internally in qemu based on latency/bandwidth specified with real units.

Also note the linux kernel HMAT latency display doesn't match up with the parameters passed in this patch series. Not sure which is at fault.

Test and results:

x86_64-softmmu/qemu-system-x86_64 -machine pc -nographic   -smp
2,sockets=2 -m 128M,slots=2,maxmem=1G
-kernel /home/dan/repos/linux/vmlinux  -append "console=ttyS0"
-object memory-backend-ram,size=64M,id=m0 -object
memory-backend-ram,size=64M,id=m1geosync -numa node,nodeid=0,memdev=m0
-numa node,nodeid=1,memdev=m1geosync,initiator=0 -numa
cpu,node-id=0,socket-id=0 -numa cpu,node-id=0,socket-id=1 -numa
hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-latency,base-lat=1000,latency=5
-numa
hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-bandwidth,base-bw=20,bandwidth=5
-numa
hmat-lb,initiator=0,target=1,hierarchy=memory,data-type=access-latency,base-lat=100,latency=10
-numa
hmat-lb,initiator=0,target=1,hierarchy=memory,data-type=access-bandwidth,base-bw=20,bandwidth=10

The Booting from ROM..[    0.000000] Linux version 5.3.0-rc2+
(dan@volution) (gcc version 9.1.1 20190503 (Red Hat 9.1.1-1) (GCC)) #21
SMP Tue Aug 6 17:15:49 AEST 2019


[    0.419303] HMAT: Memory Flags:0001 Processor Domain:0 Memory Domain:0
[    0.419648] HMAT: Memory Flags:0001 Processor Domain:0 Memory Domain:1
[    0.419956] HMAT: Locality: Flags:00 Type:Access Latency Initiator Domains:1 Target Domains:2 Base:1000
[    0.420527]   Initiator-Target[0-0]:5 nsec
[    0.420791]   Initiator-Target[0-1]:10 nsec
[    0.421068] HMAT: Locality: Flags:00 Type:Access Bandwidth Initiator Domains:1 Target Domains:2 Base:20
[    0.421447]   Initiator-Target[0-0]:100 MB/s
[    0.421635]   Initiator-Target[0-1]:200 MB/s




  reply	other threads:[~2019-08-06 23:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31  1:11 [Qemu-devel] [PATCH RESEND v8 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT) Tao Xu
2019-07-31  1:11 ` [Qemu-devel] [PATCH RESEND v8 01/11] hw/arm: simplify arm_load_dtb Tao Xu
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 02/11] numa: move numa global variable nb_numa_nodes into MachineState Tao Xu
2019-07-31 12:47   ` Igor Mammedov
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 03/11] numa: move numa global variable have_numa_distance " Tao Xu
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 04/11] numa: move numa global variable numa_info " Tao Xu
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 05/11] numa: Extend CLI to provide initiator information for numa nodes Tao Xu
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 06/11] hmat acpi: Build Memory Proximity Domain Attributes Structure(s) Tao Xu
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 07/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s) Tao Xu
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 08/11] hmat acpi: Build Memory Side Cache " Tao Xu
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 09/11] numa: Extend the CLI to provide memory latency and bandwidth information Tao Xu
2019-08-06 23:14   ` Daniel Black [this message]
2019-08-07  1:25     ` Tao Xu
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 10/11] numa: Extend the CLI to provide memory side cache information Tao Xu
2019-07-31  1:12 ` [Qemu-devel] [PATCH RESEND v8 11/11] tests/bios-tables-test: add test cases for ACPI HMAT Tao Xu
2019-08-01 11:41 ` [Qemu-devel] [PATCH RESEND v8 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT) no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190807091449.2e88b175@volution.ozlabs.ibm.com \
    --to=daniel@linux.ibm.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=fan.du@intel.com \
    --cc=imammedo@redhat.com \
    --cc=jingqi.liu@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tao3.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).