From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE89EC32751 for ; Thu, 8 Aug 2019 02:08:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8371B214C6 for ; Thu, 8 Aug 2019 02:08:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8371B214C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvXqg-0005EK-Sb for qemu-devel@archiver.kernel.org; Wed, 07 Aug 2019 22:08:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54293) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvXqJ-0004cB-0k for qemu-devel@nongnu.org; Wed, 07 Aug 2019 22:07:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvXqI-00069z-23 for qemu-devel@nongnu.org; Wed, 07 Aug 2019 22:07:50 -0400 Received: from mga06.intel.com ([134.134.136.31]:10589) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hvXqH-00069M-QQ for qemu-devel@nongnu.org; Wed, 07 Aug 2019 22:07:50 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 19:07:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,358,1559545200"; d="scan'208";a="258567240" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga001.jf.intel.com with ESMTP; 07 Aug 2019 19:07:46 -0700 Date: Thu, 8 Aug 2019 10:07:23 +0800 From: Wei Yang To: qemu-devel@nongnu.org, berrange@redhat.com, dgilbert@redhat.com, marcandre.lureau@redhat.com Message-ID: <20190808020723.GB26938@richard> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.31 Subject: [Qemu-devel] [Fail] tests/test-util-filemonitor fails X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Current qemu fails tests/test-util-filemonitor. By bisect, it shows this commit introduced the error. commit ff3dc8fefe953fd3650279e064bf63b212c5699a Author: Daniel P. Berrang茅 Date: Wed Mar 13 17:36:18 2019 +0000 filemon: ensure watch IDs are unique to QFileMonitor scope The watch IDs are mistakenly only unique within the scope of the directory being monitored. This is not useful for clients which are monitoring multiple directories. They require watch IDs to be unique globally within the QFileMonitor scope. After revert "filemon: ensure watch IDs are unique to QFileMonitor scope" "filemon: fix watch IDs to avoid potential wraparound issues" The test pass. -- Wei Yang Help you, Help me