From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A49CAC433FF for ; Tue, 13 Aug 2019 10:30:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7509320679 for ; Tue, 13 Aug 2019 10:30:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7509320679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxU4N-0004Te-PH for qemu-devel@archiver.kernel.org; Tue, 13 Aug 2019 06:30:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34927) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxU3k-0003Ia-Kx for qemu-devel@nongnu.org; Tue, 13 Aug 2019 06:29:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxU3j-0007UC-OG for qemu-devel@nongnu.org; Tue, 13 Aug 2019 06:29:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41596) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxU3j-0007Tp-Il for qemu-devel@nongnu.org; Tue, 13 Aug 2019 06:29:43 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB561307D90E; Tue, 13 Aug 2019 10:29:42 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-117-72.ams2.redhat.com [10.36.117.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 39809794C4; Tue, 13 Aug 2019 10:29:39 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com Date: Tue, 13 Aug 2019 11:29:34 +0100 Message-Id: <20190813102936.32195-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 13 Aug 2019 10:29:42 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 0/2] Fix MemoryRegionSection alignment and comparison X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: "Dr. David Alan Gilbert" This fixes a symptom I've seen on vhost-user on aarch64 where the daemon would be falsely notified of memory region changes that didn't exist. The underlying problem was me memcmp'ing MemoryRegionSections even though they had padding in. (Discovered while getting virtiofs working on aarch) Dave Dr. David Alan Gilbert (2): memory: Align and add helper for comparing MemoryRegionSections vhost: Fix memory region section comparison hw/virtio/vhost.c | 9 +++++++-- include/exec/memory.h | 14 +++++++++++++- 2 files changed, 20 insertions(+), 3 deletions(-) --=20 2.21.0