From: Wei Yang <richard.weiyang@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: quintela@redhat.com, corentincj@iksaif.net, pl@kamp.de,
qemu-devel@nongnu.org, peterx@redhat.com, kraxel@redhat.com,
Wei Yang <richardw.yang@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH] test-bitmap: test set 1 bit case for bitmap_set
Date: Wed, 14 Aug 2019 16:01:29 +0000 [thread overview]
Message-ID: <20190814160129.x3bhh7glunfw6rxn@master> (raw)
In-Reply-To: <2ff8a0a8-f665-1bb4-5073-1697bee22bfc@redhat.com>
On Wed, Aug 14, 2019 at 02:38:24PM +0200, Paolo Bonzini wrote:
>On 14/08/19 02:27, Wei Yang wrote:
>> All current bitmap_set test cases set range across word, while the
>> handle of a range within one word is different from that.
>>
>> Add case to set 1 bit as a represent for set range within one word.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>
>> ---
>> Thanks for Paolo's finding.
>>
>> ---
>> tests/test-bitmap.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/tests/test-bitmap.c b/tests/test-bitmap.c
>> index 18aa584591..087e02a26c 100644
>> --- a/tests/test-bitmap.c
>> +++ b/tests/test-bitmap.c
>> @@ -67,6 +67,18 @@ static void bitmap_set_case(bmap_set_func set_func)
>>
>> bmap = bitmap_new(BMAP_SIZE);
>>
>> + /* Set one bit at offset in second word */
>> + for (offset = 0; offset <= BITS_PER_LONG; offset++) {
>> + bitmap_clear(bmap, 0, BMAP_SIZE);
>> + set_func(bmap, BITS_PER_LONG + offset, 1);
>> + g_assert_cmpint(find_first_bit(bmap, 2 * BITS_PER_LONG),
>> + ==, BITS_PER_LONG + offset);
>> + g_assert_cmpint(find_next_zero_bit(bmap,
>> + 3 * BITS_PER_LONG,
>> + BITS_PER_LONG + offset),
>> + ==, BITS_PER_LONG + offset + 1);
>> + }
>> +
>> /* Both Aligned, set bits [BITS_PER_LONG, 3*BITS_PER_LONG] */
>> set_func(bmap, BITS_PER_LONG, 2 * BITS_PER_LONG);
>> g_assert_cmpuint(bmap[1], ==, -1ul);
>>
>
>Queued, thanks for writing the testcase without no one asking! :)
>
My pleasure to help :)
>Paolo
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2019-08-14 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 0:27 [Qemu-devel] [PATCH] test-bitmap: test set 1 bit case for bitmap_set Wei Yang
2019-08-14 12:38 ` Paolo Bonzini
2019-08-14 16:01 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814160129.x3bhh7glunfw6rxn@master \
--to=richard.weiyang@gmail.com \
--cc=corentincj@iksaif.net \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).