From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com
Cc: peter.maydell@linaro.org, maxime.coquelin@redhat.com,
marcandre.lureau@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] Fix MemoryRegionSection alignment and comparison
Date: Wed, 14 Aug 2019 18:55:32 +0100 [thread overview]
Message-ID: <20190814175535.2023-1-dgilbert@redhat.com> (raw)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
This fixes a symptom I've seen on vhost-user on aarch64 where the
daemon would be falsely notified of memory region changes that didn't
exist.
The underlying problem was me memcmp'ing MemoryRegionSections even
though they had padding in.
(Discovered while getting virtiofs working on aarch)
Dave
v2
Split 1st patch and fix spelling [Philippe's review]
Dr. David Alan Gilbert (3):
memory: Align MemoryRegionSections fields
memory: Provide an equality function for MemoryRegionSections
vhost: Fix memory region section comparison
hw/virtio/vhost.c | 9 +++++++--
include/exec/memory.h | 14 +++++++++++++-
2 files changed, 20 insertions(+), 3 deletions(-)
--
2.21.0
next reply other threads:[~2019-08-14 17:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 17:55 Dr. David Alan Gilbert (git) [this message]
2019-08-14 17:55 ` [Qemu-devel] [PATCH v2 1/3] memory: Align MemoryRegionSections fields Dr. David Alan Gilbert (git)
2019-09-25 14:30 ` [PULL " Michael S. Tsirkin
2019-08-14 17:55 ` [Qemu-devel] [PATCH v2 2/3] memory: Provide an equality function for MemoryRegionSections Dr. David Alan Gilbert (git)
2019-09-25 14:30 ` [PULL " Michael S. Tsirkin
2019-08-14 17:55 ` [Qemu-devel] [PATCH v2 3/3] vhost: Fix memory region section comparison Dr. David Alan Gilbert (git)
2019-09-25 14:30 ` [PULL " Michael S. Tsirkin
2019-08-15 2:16 ` [Qemu-devel] [PATCH v2 0/3] Fix MemoryRegionSection alignment and comparison no-reply
2019-09-25 14:30 [PULL 0/3] vhost: fixes Michael S. Tsirkin
2019-09-27 10:10 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814175535.2023-1-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).