From: David Gibson <david@gibson.dropbear.id.au>
To: Paul Clarke <pc@us.ibm.com>
Cc: qemu-ppc@nongnu.org, richard.henderson@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction
Date: Thu, 15 Aug 2019 09:57:40 +1000 [thread overview]
Message-ID: <20190814235740.GB13050@umbus.fritz.box> (raw)
In-Reply-To: <3ff4c0cd-b757-55e3-c675-cbfd74a7f76e@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
On Wed, Aug 14, 2019 at 11:34:13AM -0500, Paul Clarke wrote:
> Should these 'checkpatch' ERRORs be addressed, even if it will diverge the code style from the existing, surrounding code?
>
> On 8/14/19 11:30 AM, no-reply@patchew.org wrote:
> > This series seems to have some coding style problems. See output below for
> > more information:
>
> > === OUTPUT BEGIN ===
> > ERROR: code indent should never use tabs
> > #54: FILE: disas/ppc.c:5004:
> > +{ "mffsl", XRA(63,583,12), XRARB_MASK,^IPOWER9,^I{ FRT } },$
> >
> > ERROR: space required after that ',' (ctx:VxV)
> > #54: FILE: disas/ppc.c:5004:
> > +{ "mffsl", XRA(63,583,12), XRARB_MASK, POWER9, { FRT } },
> > ^
> >
> > ERROR: space required after that ',' (ctx:VxV)
> > #54: FILE: disas/ppc.c:5004:
> > +{ "mffsl", XRA(63,583,12), XRARB_MASK, POWER9, { FRT } },
The ones above, no.
> > ERROR: braces {} are necessary for all arms of this statement
> > #148: FILE: target/ppc/translate/fp-impl.inc.c:625:
> > + if (unlikely(!(ctx->insns_flags2 & PPC2_ISA300)))
But this one, yes.
> > [...]
> >
> > total: 4 errors, 0 warnings, 115 lines checked
> >
> > Commit c51c0f894525 (ppc: Add support for 'mffsl' instruction) has style problems, please review. If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
> > === OUTPUT END ===
>
> PC
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-14 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 16:14 [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction Paul A. Clarke
2019-08-14 16:30 ` no-reply
2019-08-14 16:34 ` Paul Clarke
2019-08-14 23:57 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814235740.GB13050@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=pc@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).