From: Gerd Hoffmann <kraxel@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] ati-vga: Implement dummy VBlank IRQ
Date: Thu, 15 Aug 2019 11:50:36 +0200 [thread overview]
Message-ID: <20190815095036.lon6sw6cft2agdzw@sirius.home.kraxel.org> (raw)
In-Reply-To: <alpine.BSF.2.21.9999.1908151051570.23526@zero.eik.bme.hu>
Hi,
> > > +static void ati_vga_update_irq(ATIVGAState *s)
> > > +{
> > > + pci_set_irq(&s->dev, s->regs.gen_int_status & 1);
> >
> > This should be "s->regs.gen_int_status & s->regs.gen_int_cntl" I guess?
>
> Probably, but we only try to emulate VBlank yet so to avoid any problems due
> to raising irq for unknown bits I restricted it for that now.
Well, qemu doesn't set unknown status bits, only vblank. The guest
can't set them either due to status register having write-one-to-clear
semantics. So, that should not happen. If you want an extra check to
catch programming errors I'd suggest to add an assert() for that.
> > > + s->regs.gen_int_status &= ~data;
> >
> > ati_vga_update_irq() needed here too.
>
> Thanks. Indeed I forgot this. With that it works a bit better, mouse now can
> be moved but only vertically... No idea why, I'll have to check,
Still progress. One step at a time ;)
cheers,
Gerd
next prev parent reply other threads:[~2019-08-15 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 0:25 [Qemu-devel] [RFC PATCH] ati-vga: Implement dummy VBlank IRQ BALATON Zoltan
2019-08-15 6:23 ` Gerd Hoffmann
2019-08-15 9:19 ` BALATON Zoltan
2019-08-15 9:50 ` Gerd Hoffmann [this message]
2019-08-15 11:17 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815095036.lon6sw6cft2agdzw@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).