qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yuval Shaia <yuval.shaia@oracle.com>
To: Stephen Kitt <steve@sk2.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix hw/rdma/vmw/pvrdma_cmd.c build
Date: Thu, 15 Aug 2019 13:57:05 +0300	[thread overview]
Message-ID: <20190815105704.GA3018@lap1> (raw)
In-Reply-To: <20190811194247.9861-1-steve@sk2.org>

On Sun, Aug 11, 2019 at 09:42:47PM +0200, Stephen Kitt wrote:
> This was broken by the cherry-pick in 41dd30f. Fix by handling errors
> as in the rest of the function: "goto out" instead of "return rc".
> 
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
>  hw/rdma/vmw/pvrdma_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
> index bb9a9f1cd1..a3a86d7c8e 100644
> --- a/hw/rdma/vmw/pvrdma_cmd.c
> +++ b/hw/rdma/vmw/pvrdma_cmd.c
> @@ -514,7 +514,7 @@ static int create_qp(PVRDMADev *dev, union pvrdma_cmd_req *req,
>                                       cmd->recv_cq_handle, rings, &resp->qpn);
>      if (resp->hdr.err) {
>          destroy_qp_rings(rings);
> -        return rc;
> +        goto out;

This label was removed, can you please check master branch?

>      }
>  
>      resp->max_send_wr = cmd->max_send_wr;
> -- 
> 2.20.1
> 
> 


  reply	other threads:[~2019-08-15 10:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-11 19:42 [Qemu-devel] [PATCH] Fix hw/rdma/vmw/pvrdma_cmd.c build Stephen Kitt
2019-08-15 10:57 ` Yuval Shaia [this message]
2019-08-15 12:12   ` Stephen Kitt
2019-08-18 12:28     ` Yuval Shaia
2019-08-18 21:50       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190815105704.GA3018@lap1 \
    --to=yuval.shaia@oracle.com \
    --cc=qemu-devel@nongnu.org \
    --cc=steve@sk2.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).