From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0755DC3A589 for ; Thu, 15 Aug 2019 15:44:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFE3C20665 for ; Thu, 15 Aug 2019 15:44:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFE3C20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyHvp-0005nj-Vo for qemu-devel@archiver.kernel.org; Thu, 15 Aug 2019 11:44:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39362) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyHqf-00085u-T7 for qemu-devel@nongnu.org; Thu, 15 Aug 2019 11:39:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyHqc-0001FJ-3P for qemu-devel@nongnu.org; Thu, 15 Aug 2019 11:39:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44488) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyHqb-0001Ew-Ts; Thu, 15 Aug 2019 11:39:30 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2571E2A09DC; Thu, 15 Aug 2019 15:39:29 +0000 (UTC) Received: from gondolin (ovpn-116-91.ams2.redhat.com [10.36.116.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0C373796; Thu, 15 Aug 2019 15:39:24 +0000 (UTC) Date: Thu, 15 Aug 2019 17:39:22 +0200 From: Cornelia Huck To: Thomas Huth Message-ID: <20190815173922.65d6c12a.cohuck@redhat.com> In-Reply-To: <8f5a49d2-49f3-f7b4-220b-fe2542b751c2@redhat.com> References: <20190814072355.15333-1-david@redhat.com> <20190814072355.15333-5-david@redhat.com> <8f5a49d2-49f3-f7b4-220b-fe2542b751c2@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 15 Aug 2019 15:39:29 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v2 4/6] s390x/mmu: Trace the right value if setting/getting the storage key fails X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Janosch Frank , David Hildenbrand , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 14 Aug 2019 19:50:44 +0200 Thomas Huth wrote: > On 8/14/19 9:23 AM, David Hildenbrand wrote: > > We want to trace the actual return value, not "0". > > > > Reviewed-by: Cornelia Huck > > Signed-off-by: David Hildenbrand > > --- > > target/s390x/mmu_helper.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > Fixes: 0f5f669147b52f89928bdf180165f74c4219210e Better: Fixes: 0f5f669147b5 ("s390x: Enable new s390-storage-keys device") > Reviewed-by: Thomas Huth