From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Krempa <pkrempa@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Like Xu <like.xu@linux.intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 0/3] pc: Fix die-id validation and compatibility with libvirt
Date: Thu, 15 Aug 2019 15:38:00 -0300 [thread overview]
Message-ID: <20190815183803.13346-1-ehabkost@redhat.com> (raw)
Currently, if die-id is omitted on -device for CPUs, we get a
very confusing error message:
$ qemu-system-x86_64 -smp 1,sockets=6,maxcpus=6 \
-device qemu64-x86_64-cpu,socket-id=1,core-id=0,thread-id=0
qemu-system-x86_64: -device qemu64-x86_64-cpu,socket-id=1,core-id=0,thread-id=0: \
Invalid CPU die-id: 4294967295 must be in range 0:5
This has 3 problems
1) The actual range for die-id is 0:0.
This is fixed by patch 1/3.
2) The user didn't specify die-id=4294967295.
This is fixed by patch 2/3.
3) It breaks compatibility with libvirt because die-id was not
mandatory before.
This is addressed by patch 3/3.
Issues #1 and #2 were reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=1741151
Issue #3 was reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=1741451
Cc: Like Xu <like.xu@linux.intel.com>
Cc: Peter Krempa <pkrempa@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Eduardo Habkost (3):
pc: Fix error message on die-id validation
pc: Improve error message when die-id is omitted
pc: Don't make CPU properties mandatory unless necessary
hw/i386/pc.c | 23 ++++++++-
tests/acceptance/pc_cpu_hotplug_props.py | 59 ++++++++++++++++++++++++
2 files changed, 81 insertions(+), 1 deletion(-)
create mode 100644 tests/acceptance/pc_cpu_hotplug_props.py
--
2.21.0
next reply other threads:[~2019-08-15 18:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 18:38 Eduardo Habkost [this message]
2019-08-15 18:38 ` [Qemu-devel] [PATCH 1/3] pc: Fix error message on die-id validation Eduardo Habkost
2019-08-15 20:04 ` Vanderson Martins do Rosario
2019-08-16 1:04 ` Like Xu
2019-08-16 13:49 ` Eduardo Habkost
2019-08-19 0:53 ` Like Xu
2019-08-16 6:06 ` Markus Armbruster
2019-08-16 14:04 ` Igor Mammedov
2019-08-15 18:38 ` [Qemu-devel] [PATCH 2/3] pc: Improve error message when die-id is omitted Eduardo Habkost
2019-08-15 20:11 ` Vanderson Martins do Rosario
2019-08-16 14:06 ` Igor Mammedov
2019-08-15 18:38 ` [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary Eduardo Habkost
2019-08-16 6:10 ` Markus Armbruster
2019-08-16 7:49 ` Erik Skultety
2019-08-16 12:22 ` Markus Armbruster
2019-08-16 17:42 ` Eduardo Habkost
2019-08-16 21:07 ` Yash Mankad
2019-08-20 21:06 ` Eduardo Habkost
2019-08-17 5:34 ` Markus Armbruster
2019-08-16 16:49 ` Eduardo Habkost
2019-08-16 13:20 ` Igor Mammedov
2019-08-16 16:56 ` Eduardo Habkost
2019-08-17 6:17 ` Markus Armbruster
2019-08-26 14:51 ` Igor Mammedov
2019-08-27 16:15 ` Markus Armbruster
2019-08-28 15:27 ` Igor Mammedov
2019-08-19 19:19 ` [Qemu-devel] [PATCH 0/3] pc: Fix die-id validation and compatibility with libvirt Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815183803.13346-1-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=like.xu@linux.intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).