From: David Gibson <david@gibson.dropbear.id.au>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: frederic.konrad@adacore.com, berto@igalia.com,
qemu-block@nongnu.org, arikalo@wavecomp.com, pasic@linux.ibm.com,
hpoussin@reactos.org, anthony.perard@citrix.com,
xen-devel@lists.xenproject.org, jasowang@redhat.com,
jiri@resnulli.us, ehabkost@redhat.com, b.galvani@gmail.com,
eric.auger@redhat.com, alex.williamson@redhat.com,
stefanha@redhat.com, jsnow@redhat.com, rth@twiddle.net,
kwolf@redhat.com, andrew@aj.id.au, claudio.fontana@suse.com,
crwulff@gmail.com, laurent@vivier.eu, sundeep.lkml@gmail.com,
michael@walle.cc, qemu-ppc@nongnu.org,
kbastian@mail.uni-paderborn.de, imammedo@redhat.com,
fam@euphon.net, peter.maydell@linaro.org, david@redhat.com,
palmer@sifive.com, keith.busch@intel.com, jcmvbkbc@gmail.com,
hare@suse.com, sstabellini@kernel.org, andrew.smirnov@gmail.com,
deller@gmx.de, magnus.damm@gmail.com, atar4qemu@gmail.com,
minyard@acm.org, sw@weilnetz.de, yuval.shaia@oracle.com,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
peter.chubb@nicta.com.au, clg@kaod.org, shorne@gmail.com,
qemu-riscv@nongnu.org, i.mitsyanko@gmail.com, cohuck@redhat.com,
amarkovic@wavecomp.com, jan.kiszka@web.de, aurelien@aurel32.net,
pburton@wavecomp.com, sagark@eecs.berkeley.edu,
green@moxielogic.com, kraxel@redhat.com,
edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, robh@kernel.org,
borntraeger@de.ibm.com, joel@jms.id.au, antonynpavlov@gmail.com,
chouteau@adacore.com, lersek@redhat.com,
Andrew.Baumann@microsoft.com, mreitz@redhat.com,
walling@linux.ibm.com, dmitry.fleytman@gmail.com, mst@redhat.com,
mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org,
jslaby@suse.cz, marex@denx.de, proljc@gmail.com,
marcandre.lureau@redhat.com, alistair@alistair23.me,
paul.durrant@citrix.com, tony.nguyen@bt.com,
xiaoguangrong.eric@gmail.com, huth@tuxfamily.org,
jcd@tribudubois.net, pbonzini@redhat.com, stefanb@linux.ibm.com
Subject: Re: [Qemu-devel] [PATCH v7 00/42] Invert Endian bit in SPARCv9 MMU TTE
Date: Fri, 16 Aug 2019 21:43:05 +1000
Message-ID: <20190816114305.GB2259@umbus.fritz.box> (raw)
In-Reply-To: <a7d6eede-b152-4c06-8945-9607c663b99c@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]
On Fri, Aug 16, 2019 at 11:58:05AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Tony,
>
> On 8/16/19 8:28 AM, tony.nguyen@bt.com wrote:
> > This patchset implements the IE (Invert Endian) bit in SPARCv9 MMU TTE.
> >
> > v7:
> [...]
> > - Re-declared many native endian devices as little or big endian. This is why
> > v7 has +16 patches.
>
> Why are you doing that? What is the rational?
>
> Anyhow if this not required by your series, you should split it out of
> it, and send it on your principal changes are merged.
> I'm worried because this these new patches involve many subsystems (thus
> maintainers) and reviewing them will now take a fair amount of time.
>
> > For each device declared with DEVICE_NATIVE_ENDIAN, find the set of
> > targets from the set of target/hw/*/device.o.
> >
> > If the set of targets are all little or all big endian, re-declare
> > the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN
> > respectively.
>
> If only little endian targets use a device, that doesn't mean the device
> is designed in little endian...
>
> Then if a big endian target plan to use this device, it will require
> more work and you might have introduced regressions...
Uh.. only if they make the version of the device on a big endian
target big endian. Which is a terrible idea - if you know a hardware
designer planning to do this, please slap them.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply index
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 6:28 tony.nguyen
2019-08-16 7:08 ` [Qemu-devel] [PATCH v7 01/42] configure: Define TARGET_ALIGNED_ONLY tony.nguyen
2019-08-16 7:26 ` [Qemu-devel] [PATCH v7 02/42] tcg: TCGMemOp is now accelerator independent MemOp tony.nguyen
2019-08-16 7:27 ` [Qemu-devel] [PATCH v7 03/42] memory: Introduce size_memop tony.nguyen
2019-08-16 7:27 ` [Qemu-devel] [PATCH v7 04/42] target/mips: Access MemoryRegion with MemOp tony.nguyen
2019-08-16 7:28 ` [Qemu-devel] [PATCH v7 05/42] hw/s390x: " tony.nguyen
2019-08-16 7:28 ` [Qemu-devel] [PATCH v7 06/42] hw/intc/armv7m_nic: " tony.nguyen
2019-08-16 7:28 ` [Qemu-devel] [PATCH v7 07/42] hw/virtio: " tony.nguyen
2019-08-16 7:29 ` [Qemu-devel] [PATCH v7 08/42] hw/vfio: " tony.nguyen
2019-08-16 7:29 ` [Qemu-devel] [PATCH v7 09/42] exec: " tony.nguyen
2019-08-16 7:30 ` [Qemu-devel] [PATCH v7 10/42] cputlb: " tony.nguyen
2019-08-16 7:30 ` [Qemu-devel] [PATCH v7 11/42] memory: " tony.nguyen
2019-08-18 21:44 ` Philippe Mathieu-Daudé
2019-08-16 7:30 ` [Qemu-devel] [PATCH v7 12/42] hw/s390x: Hard code size with MO_{8|16|32|64} tony.nguyen
2019-08-16 7:31 ` [Qemu-devel] [PATCH v7 13/42] target/mips: " tony.nguyen
2019-08-16 7:31 ` [Qemu-devel] [PATCH v7 14/42] exec: " tony.nguyen
2019-08-16 7:31 ` [Qemu-devel] [PATCH v7 15/42] hw/audio: Declare device little or big endian tony.nguyen
2019-08-16 7:32 ` [Qemu-devel] [PATCH v7 16/42] hw/block: " tony.nguyen
2019-08-16 7:32 ` [Qemu-devel] [PATCH v7 17/42] hw/char: " tony.nguyen
2019-08-16 7:32 ` [Qemu-devel] [PATCH v7 18/42] hw/display: " tony.nguyen
2019-08-16 7:33 ` [Qemu-devel] [PATCH v7 19/42] hw/dma: " tony.nguyen
2019-08-16 7:33 ` [Qemu-devel] [PATCH v7 20/42] hw/gpio: " tony.nguyen
2019-08-16 7:33 ` [Qemu-devel] [PATCH v7 21/42] hw/i2c: " tony.nguyen
2019-08-16 7:33 ` [Qemu-devel] [PATCH v7 22/42] hw/input: " tony.nguyen
2019-08-16 7:34 ` [Qemu-devel] [PATCH v7 23/42] hw/intc: " tony.nguyen
2019-08-16 7:34 ` [Qemu-devel] [PATCH v7 24/42] hw/isa: " tony.nguyen
2019-08-16 10:01 ` Philippe Mathieu-Daudé
2019-08-16 7:34 ` [Qemu-devel] [PATCH v7 25/42] hw/misc: " tony.nguyen
2019-08-16 10:04 ` Philippe Mathieu-Daudé
2019-08-19 18:26 ` Paolo Bonzini
2019-08-16 7:35 ` [Qemu-devel] [PATCH v7 26/42] hw/net: " tony.nguyen
2019-08-16 7:35 ` [Qemu-devel] [PATCH v7 27/42] hw/pci-host: " tony.nguyen
2019-08-16 10:06 ` Philippe Mathieu-Daudé
2019-08-16 7:35 ` [Qemu-devel] [PATCH v7 28/42] hw/sd: " tony.nguyen
2019-08-16 7:35 ` [Qemu-devel] [PATCH v7 29/42] hw/ssi: " tony.nguyen
2019-08-16 7:36 ` [Qemu-devel] [PATCH v7 30/42] hw/timer: " tony.nguyen
2019-08-16 7:36 ` [Qemu-devel] [PATCH v7 31/42] build: Correct non-common common-obj-* to obj-* tony.nguyen
2019-08-16 7:36 ` [Qemu-devel] [PATCH v7 32/42] exec: Map device_endian onto MemOp tony.nguyen
2019-08-16 7:37 ` [Qemu-devel] [PATCH v7 33/42] exec: Replace device_endian with MemOp tony.nguyen
2019-08-16 10:12 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2019-08-19 18:28 ` Paolo Bonzini
2019-08-19 18:29 ` Paolo Bonzini
2019-08-19 21:01 ` Richard Henderson
2019-08-20 3:11 ` Edgar E. Iglesias
2019-08-16 7:37 ` [Qemu-devel] [PATCH v7 34/42] exec: Delete device_endian tony.nguyen
2019-08-16 7:37 ` [Qemu-devel] [PATCH v7 35/42] exec: Delete DEVICE_HOST_ENDIAN tony.nguyen
2019-08-16 7:38 ` [Qemu-devel] [PATCH v7 36/42] memory: Access MemoryRegion with endianness tony.nguyen
2019-08-18 12:22 ` Richard Henderson
2019-08-16 7:38 ` [Qemu-devel] [PATCH v7 37/42] cputlb: Replace size and endian operands for MemOp tony.nguyen
2019-08-18 12:37 ` Richard Henderson
2019-08-16 7:38 ` [Qemu-devel] [PATCH v7 38/42] memory: Single byte swap along the I/O path tony.nguyen
2019-08-18 12:46 ` Richard Henderson
2019-08-16 7:39 ` [Qemu-devel] [PATCH v7 39/42] cpu: TLB_FLAGS_MASK bit to force memory slow path tony.nguyen
2019-08-16 7:39 ` [Qemu-devel] [PATCH v7 40/42] cputlb: Byte swap memory transaction attribute tony.nguyen
2019-08-16 7:39 ` [Qemu-devel] [PATCH v7 41/42] target/sparc: Add TLB entry with attributes tony.nguyen
2019-08-16 7:39 ` [Qemu-devel] [PATCH v7 42/42] target/sparc: sun4u Invert Endian TTE bit tony.nguyen
2019-08-16 8:03 ` [Qemu-devel] [PATCH v7 33/42] exec: Replace device_endian with MemOp tony.nguyen
2019-08-16 9:33 ` tony.nguyen
2019-08-16 9:58 ` [Qemu-devel] [PATCH v7 00/42] Invert Endian bit in SPARCv9 MMU TTE Philippe Mathieu-Daudé
2019-08-16 11:37 ` tony.nguyen
2019-08-16 12:02 ` Peter Maydell
2019-08-16 11:43 ` David Gibson [this message]
2019-08-18 9:13 ` Richard Henderson
Reply instructions:
You may reply publically to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816114305.GB2259@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=Andrew.Baumann@microsoft.com \
--cc=alex.williamson@redhat.com \
--cc=alistair@alistair23.me \
--cc=amarkovic@wavecomp.com \
--cc=andrew.smirnov@gmail.com \
--cc=andrew@aj.id.au \
--cc=anthony.perard@citrix.com \
--cc=antonynpavlov@gmail.com \
--cc=arikalo@wavecomp.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=berto@igalia.com \
--cc=borntraeger@de.ibm.com \
--cc=chouteau@adacore.com \
--cc=claudio.fontana@suse.com \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=crwulff@gmail.com \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=dmitry.fleytman@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=fam@euphon.net \
--cc=frederic.konrad@adacore.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=hare@suse.com \
--cc=hpoussin@reactos.org \
--cc=huth@tuxfamily.org \
--cc=i.mitsyanko@gmail.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=jcd@tribudubois.net \
--cc=jcmvbkbc@gmail.com \
--cc=jiri@resnulli.us \
--cc=joel@jms.id.au \
--cc=jslaby@suse.cz \
--cc=jsnow@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=keith.busch@intel.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=lersek@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=minyard@acm.org \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=palmer@sifive.com \
--cc=pasic@linux.ibm.com \
--cc=paul.durrant@citrix.com \
--cc=pbonzini@redhat.com \
--cc=pburton@wavecomp.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=shorne@gmail.com \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanha@redhat.com \
--cc=sundeep.lkml@gmail.com \
--cc=sw@weilnetz.de \
--cc=tony.nguyen@bt.com \
--cc=walling@linux.ibm.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
QEMU-Devel Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
qemu-devel@nongnu.org
public-inbox-index qemu-devel
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git