From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C2A9C3A5A0 for ; Mon, 19 Aug 2019 14:54:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EEB82082A for ; Mon, 19 Aug 2019 14:54:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EEB82082A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzj2z-0003j3-Ds for qemu-devel@archiver.kernel.org; Mon, 19 Aug 2019 10:54:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40123) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzj1s-00035I-4H for qemu-devel@nongnu.org; Mon, 19 Aug 2019 10:53:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzj1q-0003Hj-Tz for qemu-devel@nongnu.org; Mon, 19 Aug 2019 10:53:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61473) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzj1q-0003HQ-On for qemu-devel@nongnu.org; Mon, 19 Aug 2019 10:53:02 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E7BAD3091782; Mon, 19 Aug 2019 14:53:01 +0000 (UTC) Received: from localhost.localdomain (ovpn-124-60.rdu2.redhat.com [10.10.124.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11A881D9; Mon, 19 Aug 2019 14:52:55 +0000 (UTC) Date: Mon, 19 Aug 2019 10:52:53 -0400 From: Cleber Rosa To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Message-ID: <20190819145253.GA7887@localhost.localdomain> References: <20190818231827.27573-1-philmd@redhat.com> <20190818231827.27573-2-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190818231827.27573-2-philmd@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 19 Aug 2019 14:53:02 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 1/4] tests/docker: Use one package per line to improve readability X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Aug 19, 2019 at 01:18:24AM +0200, Philippe Mathieu-Daud=E9 wrote: > Use one package per line to improve readability. This also > helps while reviewing patches. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > tests/docker/dockerfiles/travis.docker | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dock= erfiles/travis.docker > index e72dc85ca7..35714664a1 100644 > --- a/tests/docker/dockerfiles/travis.docker > +++ b/tests/docker/dockerfiles/travis.docker > @@ -5,7 +5,15 @@ ENV LC_ALL en_US.UTF-8 > RUN sed -i "s/# deb-src/deb-src/" /etc/apt/sources.list > RUN apt-get update > RUN apt-get -y build-dep qemu > -RUN apt-get -y install device-tree-compiler python2.7 python-yaml dh-a= utoreconf gdb strace lsof net-tools gcovr > +RUN apt-get -y install \ > + device-tree-compiler \ > + dh-autoreconf \ > + gcovr \ > + gdb strace \ Two in a single line here. > + lsof \ > + net-tools \ > + python2.7 \ > + python-yaml > # Travis tools require PhantomJS / Neo4j / Maven accessible > # in their PATH (QEMU build won't access them). > ENV PATH /usr/local/phantomjs/bin:/usr/local/phantomjs:/usr/local/neo4= j-3.2.7/bin:/usr/local/maven-3.5.2/bin:/usr/local/cmake-3.9.2/bin:/usr/lo= cal/clang-5.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sb= in:/bin > --=20 > 2.20.1 >=20 >=20