From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F9FC3A5A0 for ; Mon, 19 Aug 2019 16:38:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39D172070B for ; Mon, 19 Aug 2019 16:38:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39D172070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzkft-0000rL-Bm for qemu-devel@archiver.kernel.org; Mon, 19 Aug 2019 12:38:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40381) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzkeo-0008Fc-Lk for qemu-devel@nongnu.org; Mon, 19 Aug 2019 12:37:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzken-0008P7-Dy for qemu-devel@nongnu.org; Mon, 19 Aug 2019 12:37:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39988) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzken-0008Nd-7y; Mon, 19 Aug 2019 12:37:21 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 749C730860C6; Mon, 19 Aug 2019 16:37:20 +0000 (UTC) Received: from gondolin (unknown [10.36.116.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D54527C46; Mon, 19 Aug 2019 16:37:15 +0000 (UTC) Date: Mon, 19 Aug 2019 18:37:13 +0200 From: Cornelia Huck To: David Hildenbrand Message-ID: <20190819183713.7d0016fa.cohuck@redhat.com> In-Reply-To: <20190819183623.3afe92c4.cohuck@redhat.com> References: <20190814072355.15333-1-david@redhat.com> <20190819183623.3afe92c4.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Mon, 19 Aug 2019 16:37:20 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH-for-4.2 v2 0/6] s390x/mmu: Storage key reference and change bit handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Janosch Frank , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 19 Aug 2019 18:36:23 +0200 Cornelia Huck wrote: > On Wed, 14 Aug 2019 09:23:49 +0200 > David Hildenbrand wrote: > > > The first two patches are modified patches from: > > [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions > > > > This series primarily fixes minor things in the storage key handling code > > in the MMU and implements fairly reliable reference and change bit handling > > for TCG. To track the reference and change bit, we have to invalidate > > TLB entries whenever the storage key is changed by the guest and make sure > > not TLB entry is writable in case the storage key does not indicate a > > change already. > > > > With this series, the kvm-unit-test "skey" now passes. \o/ > > > > v1 -> v2: > > - "s390x/tcg: Rework MMU selection for instruction fetches" > > -- Cleanup return value handling > > - Added RB's > > > > David Hildenbrand (6): > > s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug() > > s390x/tcg: Rework MMU selection for instruction fetches > > s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE > > s390x/mmu: Trace the right value if setting/getting the storage key > > fails > > s390x/mmu: Better storage key reference and change bit handling > > s390x/mmu: Factor out storage key handling > > > > target/s390x/cpu.h | 7 ++ > > target/s390x/helper.c | 5 ++ > > target/s390x/mem_helper.c | 4 ++ > > target/s390x/mmu_helper.c | 133 ++++++++++++++++++++++++-------------- > > 4 files changed, 99 insertions(+), 50 deletions(-) > > > > Thanks, applied. No, not that one, v3. Argh.