From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
qemu-devel@nongnu.org, "Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling
Date: Mon, 19 Aug 2019 18:38:16 +0200 [thread overview]
Message-ID: <20190819183816.45dd8178.cohuck@redhat.com> (raw)
In-Reply-To: <20190816084708.602-1-david@redhat.com>
On Fri, 16 Aug 2019 10:47:02 +0200
David Hildenbrand <david@redhat.com> wrote:
> The first two patches are modified patches from:
> [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions
>
> This series primarily fixes minor things in the storage key handling code
> in the MMU and implements fairly reliable reference and change bit handling
> for TCG. To track the reference and change bit, we have to invalidate
> TLB entries whenever the storage key is changed by the guest and make sure
> not TLB entry is writable in case the storage key does not indicate a
> change already.
>
> With this series, the kvm-unit-test "skey" now passes. \o/
>
> v2 -> v3:
> - Reshuffled patches to avoid a temporary uninitialized return value
> - Minor updates to patch descriptions
> - "s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE"
> -- Updated comments
> - "s390x/mmu: Factor out storage key handling"
> -- Reduce indentation
>
> v1 -> v2:
> - "s390x/tcg: Rework MMU selection for instruction fetches"
> -- Cleanup return value handling
> - Added RB's
>
> Cc: Alex Bennée <alex.bennee@linaro.org>
>
> David Hildenbrand (6):
> s390x/mmu: Trace the right value if setting/getting the storage key
> fails
> s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()
> s390x/tcg: Rework MMU selection for instruction fetches
> s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE
> s390x/mmu: Better storage key reference and change bit handling
> s390x/mmu: Factor out storage key handling
>
> target/s390x/cpu.h | 7 ++
> target/s390x/helper.c | 5 ++
> target/s390x/mem_helper.c | 10 +++
> target/s390x/mmu_helper.c | 135 ++++++++++++++++++++++++--------------
> 4 files changed, 107 insertions(+), 50 deletions(-)
>
[Now the correct one...]
Thanks, applied.
prev parent reply other threads:[~2019-08-19 16:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 8:47 [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling David Hildenbrand
2019-08-16 8:47 ` [Qemu-devel] [PATCH v3 1/6] s390x/mmu: Trace the right value if setting/getting the storage key fails David Hildenbrand
2019-08-19 9:44 ` Cornelia Huck
2019-08-16 8:47 ` [Qemu-devel] [PATCH v3 2/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug() David Hildenbrand
2019-08-16 8:47 ` [Qemu-devel] [PATCH v3 3/6] s390x/tcg: Rework MMU selection for instruction fetches David Hildenbrand
2019-08-19 9:45 ` Cornelia Huck
2019-08-16 8:47 ` [Qemu-devel] [PATCH v3 4/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE David Hildenbrand
2019-08-19 11:06 ` Alex Bennée
2019-08-16 8:47 ` [Qemu-devel] [PATCH v3 5/6] s390x/mmu: Better storage key reference and change bit handling David Hildenbrand
2019-08-16 8:47 ` [Qemu-devel] [PATCH v3 6/6] s390x/mmu: Factor out storage key handling David Hildenbrand
2019-08-19 9:46 ` [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling Cornelia Huck
2019-08-19 9:53 ` David Hildenbrand
2019-08-19 16:38 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819183816.45dd8178.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).