From: David Gibson <david@gibson.dropbear.id.au>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Use the proper include that defines 'target_ulong'
Date: Tue, 20 Aug 2019 17:32:41 +1000 [thread overview]
Message-ID: <20190820073241.GD20890@umbus> (raw)
In-Reply-To: <20190819144926.5297-1-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]
On Mon, Aug 19, 2019 at 04:49:26PM +0200, Philippe Mathieu-Daudé wrote:
> As its name implies, the Option/Architecture Vector is not target
> (per cpu) specific but arch-related.
> Use the proper arch-related header, allowing to use this header
> with non cpu-specific objects.
>
> This fixes this error when using this header with $common-obj:
>
> include/hw/ppc/spapr_ovec.h:76:44: error: unknown type name ‘target_ulong’; did you mean ‘gulong’?
> SpaprOptionVector *spapr_ovec_parse_vector(target_ulong table_addr, int vector);
> ^~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
So, the change here seems sane, but the commit message totally
confuses me. Where does the term "Option/Architecture Vector" come
from? What distinction are you drawing between per-target and
per-arch? What's the symptom if this patch is not applied?
> ---
> include/hw/ppc/spapr_ovec.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/ppc/spapr_ovec.h b/include/hw/ppc/spapr_ovec.h
> index 7891e9caac..b6b8811998 100644
> --- a/include/hw/ppc/spapr_ovec.h
> +++ b/include/hw/ppc/spapr_ovec.h
> @@ -37,7 +37,7 @@
> #ifndef SPAPR_OVEC_H
> #define SPAPR_OVEC_H
>
> -#include "cpu.h"
> +#include "exec/cpu-defs.h"
>
> typedef struct SpaprOptionVector SpaprOptionVector;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-20 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 14:49 [Qemu-devel] [PATCH] hw/ppc/spapr: Use the proper include that defines 'target_ulong' Philippe Mathieu-Daudé
2019-08-20 7:32 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820073241.GD20890@umbus \
--to=david@gibson.dropbear.id.au \
--cc=armbru@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).