From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
Kővágó@redhat.com, "Markus Armbruster" <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael Walle" <michael@walle.cc>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
Zoltán <DirtY.iCE.hu@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 12/15] paaudio: fix playback glitches
Date: Wed, 21 Aug 2019 10:41:10 +0200 [thread overview]
Message-ID: <20190821084113.1840-13-kraxel@redhat.com> (raw)
In-Reply-To: <20190821084113.1840-1-kraxel@redhat.com>
From: Kővágó, Zoltán <dirty.ice.hu@gmail.com>
Pulseaudio normally assumes that when the server wants it, the client
can generate the audio samples and send it right away. Unfortunately
this is not the case with QEMU -- it's up to the emulated system when
does it generate the samples. Buffering the samples and sending them
from a background thread is just a workaround, that doesn't work too
well. Instead enable pa's compatibility support and let pa worry about
the details.
Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
Message-id: aa4e3613122ccbaa62b1feb4e427260731f7477c.1566168923.git.DirtY.iCE.hu@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/paaudio.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/audio/paaudio.c b/audio/paaudio.c
index f3864e1d5038..c8ae1a6eca01 100644
--- a/audio/paaudio.c
+++ b/audio/paaudio.c
@@ -512,10 +512,8 @@ static pa_stream *qpa_simple_new (
flags =
PA_STREAM_INTERPOLATE_TIMING
-#ifdef PA_STREAM_ADJUST_LATENCY
- | PA_STREAM_ADJUST_LATENCY
-#endif
- | PA_STREAM_AUTO_TIMING_UPDATE;
+ | PA_STREAM_AUTO_TIMING_UPDATE
+ | PA_STREAM_EARLY_REQUESTS;
if (dev) {
/* don't move the stream if the user specified a sink/source */
--
2.18.1
next prev parent reply other threads:[~2019-08-21 8:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 8:40 [Qemu-devel] [PULL 00/15] Audio 20190821 patches Gerd Hoffmann
2019-08-21 8:40 ` [Qemu-devel] [PULL 01/15] audio: Add missing fall through comments Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 02/15] audio: reduce glob_audio_state usage Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 03/15] audio: basic support for multi backend audio Gerd Hoffmann
2019-09-09 17:18 ` Peter Maydell
2019-08-21 8:41 ` [Qemu-devel] [PULL 04/15] audio: add audiodev property to vnc and wav_capture Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 05/15] audio: add audiodev properties to frontends Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 06/15] paaudio: prepare for multiple audiodev Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 07/15] audio: audiodev= parameters no longer optional when -audiodev present Gerd Hoffmann
2019-08-25 9:44 ` Maxim Levitsky
2019-08-25 18:05 ` Zoltán Kővágó
2019-08-25 22:15 ` Maxim Levitsky
2019-08-25 23:34 ` Zoltán Kővágó
2019-08-21 8:41 ` [Qemu-devel] [PULL 08/15] paaudio: do not move stream when sink/source name is specified Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 09/15] paaudio: properly disconnect streams in fini_* Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 10/15] audio: remove audio_MIN, audio_MAX Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 11/15] audio: do not run each backend in audio_run Gerd Hoffmann
2019-08-21 8:41 ` Gerd Hoffmann [this message]
2019-08-21 8:41 ` [Qemu-devel] [PULL 13/15] audio: remove read and write pcm_ops Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 14/15] audio: use size_t where makes sense Gerd Hoffmann
2019-08-21 8:41 ` [Qemu-devel] [PULL 15/15] audio: fix memory leak reported by ASAN Gerd Hoffmann
2019-08-21 15:58 ` [Qemu-devel] [PULL 00/15] Audio 20190821 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821084113.1840-13-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=DirtY.iCE.hu@gmail.com \
--cc=Kővágó@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=michael@walle.cc \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).