From: Gerd Hoffmann <kraxel@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get
Date: Wed, 21 Aug 2019 10:54:41 +0200 [thread overview]
Message-ID: <20190821085441.5ovhnw2zvyv4ydgb@sirius.home.kraxel.org> (raw)
In-Reply-To: <ffd106b7-2310-ac52-bc33-d03c6a387c39@roeck-us.net>
Hi,
> > Yep, as long as the queue is not active this is completely harmless.
> > So we need to check a bit later. In execute() looks a bit too late
> > though, we don't have a good backup plan then.
> >
> > Does the patch below solve the problem without bad side effects?
> That seems to be working as intended. I have not seen a crash
> since I applied it. I tested it on top of v4.0 and v4.1.
Thanks. Send as formal patch now.
cheers,
Gerd
prev parent reply other threads:[~2019-08-21 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 17:45 [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get Guenter Roeck
2019-07-31 11:08 ` Philippe Mathieu-Daudé
2019-07-31 21:11 ` Guenter Roeck
2019-08-02 14:11 ` Gerd Hoffmann
2019-08-02 16:46 ` Guenter Roeck
2019-08-02 17:28 ` Guenter Roeck
2019-08-06 13:23 ` Guenter Roeck
2019-08-13 11:42 ` Gerd Hoffmann
2019-08-14 14:41 ` Guenter Roeck
2019-08-20 15:38 ` Guenter Roeck
2019-08-21 8:54 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821085441.5ovhnw2zvyv4ydgb@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=linux@roeck-us.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).