qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Corey Minyard" <minyard@acm.org>,
	"Juan Quintela" <quintela@redhat.com>,
	qemu-trivial@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
	"Jason Wang" <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 07/14] json: Move switch 'fall through' comment to correct place
Date: Wed, 21 Aug 2019 13:19:40 +0200	[thread overview]
Message-ID: <20190821111947.26580-8-laurent@vivier.eu> (raw)
In-Reply-To: <20190821111947.26580-1-laurent@vivier.eu>

From: Philippe Mathieu-Daudé <philmd@redhat.com>

Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:

  qobject/json-parser.c: In function ‘parse_literal’:
  qobject/json-parser.c:492:24: error: this statement may fall through [-Werror=implicit-fallthrough=]
    492 |     case JSON_INTEGER: {
        |                        ^
  qobject/json-parser.c:524:5: note: here
    524 |     case JSON_FLOAT:
        |     ^~~~

Correctly place the 'fall through' comment.

Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190719131425.10835-2-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 qobject/json-parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qobject/json-parser.c b/qobject/json-parser.c
index 7d23e12e3379..d083810d3782 100644
--- a/qobject/json-parser.c
+++ b/qobject/json-parser.c
@@ -519,8 +519,8 @@ static QObject *parse_literal(JSONParserContext *ctxt)
             }
             assert(ret == -ERANGE);
         }
-        /* fall through to JSON_FLOAT */
     }
+    /* fall through to JSON_FLOAT */
     case JSON_FLOAT:
         /* FIXME dependent on locale; a pervasive issue in QEMU */
         /* FIXME our lexer matches RFC 8259 in forbidding Inf or NaN,
-- 
2.21.0



  parent reply	other threads:[~2019-08-21 11:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 11:19 [Qemu-devel] [PULL 00/14] Trivial branch patches Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 01/14] test: Use g_strndup instead of plain strndup Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 02/14] misc: fix naming scheme of compatiblity arrays Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 03/14] configure: remove obsoleted $sparc_cpu variable Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 04/14] configure: fix sdl detection using sdl2-config Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 05/14] .gitignore: ignore some vhost-user* related files Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 06/14] hw/net/e1000: Fix erroneous comment Laurent Vivier
2019-08-21 11:19 ` Laurent Vivier [this message]
2019-08-21 11:19 ` [Qemu-devel] [PULL 08/14] hw/dma/omap_dma: Move switch 'fall through' comment to correct place Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 09/14] hw/ipmi: Rewrite a fall through comment Laurent Vivier
2019-08-21 11:48   ` Corey Minyard
2019-08-21 11:19 ` [Qemu-devel] [PULL 10/14] target/ppc: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 11/14] vl: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 12/14] spapr_events: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 13/14] hw/display/sm501: Remove unused include Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 14/14] hw/display: Compile various display devices as common object Laurent Vivier
2019-08-22  9:30 ` [Qemu-devel] [PULL 00/14] Trivial branch patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821111947.26580-8-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=armbru@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=minyard@acm.org \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).