From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] block: Let blockdev-create return 0 on success
Date: Fri, 23 Aug 2019 20:47:31 +0200 [thread overview]
Message-ID: <20190823184733.18929-1-mreitz@redhat.com> (raw)
Jobs are expected to return 0 on success. .bdrv_co_create() on the
other hand is a block layer function, and as such returns a non-negative
value on success.
blockdev_create_run() should translate between the two (patch 1).
Without patch 1, blockdev-create is likely to fail for VPC images.
Hence patch 2.
Max Reitz (2):
block: Let blockdev-create return 0 on success
iotests: Test blockdev-create for vpc
block/create.c | 3 +-
tests/qemu-iotests/266 | 182 +++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/266.out | 107 ++++++++++++++++++++++
tests/qemu-iotests/group | 1 +
4 files changed, 292 insertions(+), 1 deletion(-)
create mode 100755 tests/qemu-iotests/266
create mode 100644 tests/qemu-iotests/266.out
--
2.21.0
next reply other threads:[~2019-08-23 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 18:47 Max Reitz [this message]
2019-08-23 18:47 ` [Qemu-devel] [PATCH 1/2] block: Let blockdev-create return 0 on success Max Reitz
2019-08-23 18:47 ` [Qemu-devel] [PATCH 2/2] iotests: Test blockdev-create for vpc Max Reitz
2019-08-27 21:15 ` John Snow
2019-08-27 21:15 ` [Qemu-devel] [PATCH 0/2] block: Let blockdev-create return 0 on success John Snow
2019-09-02 13:32 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823184733.18929-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).