From: Cleber Rosa <crosa@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: ehabkost@redhat.com, groug@kaod.org, qemu-devel@nongnu.org,
qemu-ppc@nongnu.org, clg@kaod.org, sathnaga@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc
Date: Tue, 27 Aug 2019 12:00:36 -0400 [thread overview]
Message-ID: <20190827160036.GB25965@dhcp-17-173.bos.redhat.com> (raw)
In-Reply-To: <20190824093255.GI3027@umbus.fritz.box>
On Sat, Aug 24, 2019 at 07:32:55PM +1000, David Gibson wrote:
> On Mon, Aug 19, 2019 at 01:58:20PM +0530, sathnaga@linux.vnet.ibm.com wrote:
> > From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> >
> > Current acceptance test will not run properly in powerpc
> > environment due qemu target is different from arch, this
> > usually matches, except with bi-endian architectures like ppc64.
> > uname would return `ppc64` or `ppc64le` based `big` or `little`
> > endian but qemu `target` is always `ppc64`. Let's handle it.
> >
> > Reviewed-by: Cédric Le Goater <clg@kaod.org>
> > Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> I sent a similar patch a little while back, but it seems it got lost.
>
>
> > ---
> > tests/acceptance/avocado_qemu/__init__.py | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
> > index aee5d820ed..bd41e0443c 100644
> > --- a/tests/acceptance/avocado_qemu/__init__.py
> > +++ b/tests/acceptance/avocado_qemu/__init__.py
> > @@ -39,6 +39,9 @@ def pick_default_qemu_bin(arch=None):
> > """
> > if arch is None:
> > arch = os.uname()[4]
> > + # qemu binary path does not match arch for powerpc, handle it
> > + if 'ppc64le' in arch:
> > + arch = 'ppc64'
> > qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
> > "qemu-system-%s" % arch)
> > if is_readable_executable_file(qemu_bin_relative_path):
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
Yes, I remember that. I have the feeling the discussion evolved into
"let's do it for all other arch differences", because I found a patch
here about that. Anyway, sorry about that.
I've queued this one.
- Cleber.
prev parent reply other threads:[~2019-08-27 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 8:28 [Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc sathnaga
2019-08-24 9:32 ` David Gibson
2019-08-27 16:00 ` Cleber Rosa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827160036.GB25965@dhcp-17-173.bos.redhat.com \
--to=crosa@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sathnaga@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).