QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v5 2/4] raw: Recognize zoned backing devices
Date: Wed, 28 Aug 2019 10:32:55 +0100
Message-ID: <20190828093255.GD5573@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190823194927.23278-3-dmitry.fomichev@wdc.com>

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

On Fri, Aug 23, 2019 at 03:49:25PM -0400, Dmitry Fomichev wrote:
> +static int hdev_get_zoned_model(int fd)

Please use the enum:

  static BdrvZonedModel hdev_get_zoned_model(int fd)

> +{
> +#ifdef CONFIG_LINUX
> +    char buf[32];
> +    int ret;
> +
> +    ret = hdev_read_blk_queue_entry(fd, "zoned", buf, sizeof(buf));
> +    if (ret < 0) {
> +        ret = BLK_ZONED_MODEL_NONE;
> +        goto out;
>      }
> -    g_free(sysfspath);
> +
> +    buf[ret - 1] = 0;

The ret - 1 looks suspicious since sg_get_max_segments() does buf[ret] =
0 instead.  A comment would make it clear why ret - 1 is used here:

  buf[ret - 1] = 0; /* strip newline and NUL-terminate */

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 19:49 [Qemu-devel] [PATCH v5 0/4] virtio/block: handle " Dmitry Fomichev
2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 1/4] block: Add zoned device model property Dmitry Fomichev
2019-08-28  9:21   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 2/4] raw: Recognize zoned backing devices Dmitry Fomichev
2019-08-28  9:32   ` Stefan Hajnoczi [this message]
2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 3/4] block/ide/scsi: Set BLK_PERM_SUPPORT_ZONED Dmitry Fomichev
2019-08-28  9:34   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 4/4] raw: Don't open ZBDs if backend can't handle them Dmitry Fomichev
2019-08-28  9:38   ` Stefan Hajnoczi
2019-08-23 20:08 ` [Qemu-devel] [PATCH v5 0/4] virtio/block: handle zoned backing devices no-reply
2019-08-28  9:41 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-09-04 21:11   ` Dmitry Fomichev

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828093255.GD5573@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=alistair.francis@wdc.com \
    --cc=dmitry.fomichev@wdc.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git