From: Thomas Huth <huth@tuxfamily.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/6] m68k: Add NeXTcube keyboard device
Date: Sat, 31 Aug 2019 07:18:57 +0200 [thread overview]
Message-ID: <20190831071857.5e3f53dc@thl530.multi.box> (raw)
In-Reply-To: <CAFEAcA9uech2_Uc1XnxSm8Dk2rEAuyvxtnH74e_oCgw7ovVCaw@mail.gmail.com>
Am Tue, 13 Aug 2019 11:16:44 +0100
schrieb Peter Maydell <peter.maydell@linaro.org>:
> On Tue, 9 Jul 2019 at 08:35, Thomas Huth <huth@tuxfamily.org> wrote:
> >
> > It is likely still quite incomplete (e.g. mouse and interrupts are
> > not implemented yet), but it is good enough for keyboard input at
> > the firmware monitor.
> > This code has been taken from Bryce Lanham's GSoC 2011 NeXT branch
> > at
> >
> > https://github.com/blanham/qemu-NeXT/blob/next-cube/hw/next-kbd.c
> >
> > and altered to fit the latest interface of the current QEMU (e.g.
> > to use memory_region_init_io() instead of
> > cpu_register_physical_memory()).
> >
> > Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> > +static void nextkbd_class_init(ObjectClass *oc, void *data)
> > +{
> > + DeviceClass *dc = DEVICE_CLASS(oc);
> > +
> > + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> > + dc->realize = nextkbd_realize;
> > + dc->reset = nextkbd_reset;
> > +}
>
> This one definitely needs migration state...
m68k machines are currently unmigratable - see vmstate_m68k_cpu in
target/m68k/cpu.c. So I assume it's currently enough if I add a
".unmigratable = 1" here, too?
Thomas
next prev parent reply other threads:[~2019-08-31 5:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 7:32 [Qemu-devel] [PATCH v4 0/6] m68k: Add basic support for the NeXTcube machine Thomas Huth
2019-07-09 7:32 ` [Qemu-devel] [PATCH v4 1/6] m68k: Add NeXTcube framebuffer device emulation Thomas Huth
2019-08-13 10:11 ` Philippe Mathieu-Daudé
2019-08-13 10:15 ` Peter Maydell
2019-07-09 7:32 ` [Qemu-devel] [PATCH v4 2/6] m68k: Add NeXTcube keyboard device Thomas Huth
2019-08-13 10:13 ` Philippe Mathieu-Daudé
2019-08-13 10:16 ` Peter Maydell
2019-08-31 5:18 ` Thomas Huth [this message]
2019-09-03 9:12 ` Peter Maydell
2019-09-03 9:21 ` Thomas Huth
2019-07-09 7:32 ` [Qemu-devel] [PATCH v4 3/6] m68k: Add NeXTcube machine Thomas Huth
2019-08-13 10:20 ` Philippe Mathieu-Daudé
2019-07-09 7:32 ` [Qemu-devel] [PATCH v4 4/6] escc: introduce a selector for the register bit Thomas Huth
2019-08-13 10:21 ` Philippe Mathieu-Daudé
2019-07-09 7:32 ` [Qemu-devel] [PATCH v4 5/6] m68k: Add serial controller to the NeXTcube machine Thomas Huth
2019-08-13 10:26 ` Philippe Mathieu-Daudé
2019-07-09 7:32 ` [Qemu-devel] [PATCH v4 6/6] m68k: Add an entry for the NeXTcube machine to the MAINTAINERS file Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190831071857.5e3f53dc@thl530.multi.box \
--to=huth@tuxfamily.org \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).