From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C162C3A5A2 for ; Tue, 3 Sep 2019 15:20:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 214E422CF8 for ; Tue, 3 Sep 2019 15:19:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 214E422CF8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5Ab9-0002qH-3F for qemu-devel@archiver.kernel.org; Tue, 03 Sep 2019 11:19:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53034) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5AaP-0002Ne-U4 for qemu-devel@nongnu.org; Tue, 03 Sep 2019 11:19:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5AaM-0001Wt-7T for qemu-devel@nongnu.org; Tue, 03 Sep 2019 11:19:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58224) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i5AaI-0001TK-2y for qemu-devel@nongnu.org; Tue, 03 Sep 2019 11:19:08 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99CD5308427D; Tue, 3 Sep 2019 15:19:04 +0000 (UTC) Received: from localhost.localdomain (ovpn-123-245.rdu2.redhat.com [10.10.123.245]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6A4A60C5D; Tue, 3 Sep 2019 15:19:00 +0000 (UTC) Date: Tue, 3 Sep 2019 11:18:59 -0400 From: Cleber Rosa To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Message-ID: <20190903151859.GB14836@localhost.localdomain> References: <20190829013125.GG16342@umbus.fritz.box> <20190829015117.GH16342@umbus.fritz.box> <20190829032746.GA488@localhost.localdomain> <24d0d5be-d206-33a0-cd8c-29825e2f8516@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <24d0d5be-d206-33a0-cd8c-29825e2f8516@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 03 Sep 2019 15:19:04 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] Cryptic errors from PIP install if missing openssl-devel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ldoktor@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Aug 29, 2019 at 11:24:30AM +0200, Philippe Mathieu-Daud=E9 wrote: > Is there a way to check for this before submitting/merging patches? >=20 > Some checkpatch.py lines that report: >=20 > The 'paramiko' module is not pure Python and can > not be added in requirements.txt. > I dont think there is... at least, I can't think of one. None of the PyPI classifiers[1] seems to cover the "pure Python .vs. compiled code" installation requirements. AFAIK, this is usually buried in the setup.py code of each package, so it's not easy to inspect it. But, we can define "only Pure Python modules" as a policy, document it and hopefully flag it on code review. [1] https://pypi.org/classifiers/ - Cleber.