From: Eduardo Habkost <ehabkost@redhat.com>
To: Tao Xu <tao3.xu@intel.com>
Cc: "imammedo@redhat.com" <imammedo@redhat.com>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node
Date: Wed, 4 Sep 2019 17:43:47 -0300 [thread overview]
Message-ID: <20190904204347.GC4617@habkost.net> (raw)
In-Reply-To: <428a67b2-4bf4-b9ab-b06e-f06bc12e721d@intel.com>
On Wed, Sep 04, 2019 at 02:22:39PM +0800, Tao Xu wrote:
> On 9/4/2019 1:52 AM, Eduardo Habkost wrote:
> > On Mon, Aug 05, 2019 at 03:13:02PM +0800, Tao Xu wrote:
> > > Add MachineClass::auto_enable_numa field. When it is true, a NUMA node
> > > is expected to be created implicitly.
> > >
> > > Acked-by: David Gibson <david@gibson.dropbear.id.au>
> > > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > > Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
> > > Signed-off-by: Tao Xu <tao3.xu@intel.com>
> >
> > This introduces spurious warnings when running qemu-system-ppc64.
> > See: https://lore.kernel.org/qemu-devel/CAFEAcA-AvFS2cbDH-t5SxgY9hA=LGL81_8dn-vh193vtV9W1Lg@mail.gmail.com/
> >
> > To reproduce it, just run 'qemu-system-ppc64 -machine pseries'
> > without any -numa arguments.
> >
> > I have removed this patch from machine-next so it won't block the
> > existing pull request.
> >
> I got it. If default splitting of RAM between nodes is
> deprecated, this patch can't reuse the splitting code. I agree with droping
> this patch.
Probably all we need to fix this issue is to replace
NumaNodeOptions node = { };
with
NumaNodeOptions node = { .size = ram_size };
in the auto_enable_numa block.
Do you plan to send v2?
--
Eduardo
next prev parent reply other threads:[~2019-09-04 21:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 7:13 [Qemu-devel] [PATCH] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node Tao Xu
2019-08-06 12:50 ` Igor Mammedov
2019-08-07 17:52 ` Eduardo Habkost
2019-08-08 6:35 ` David Gibson
2019-08-08 6:35 ` David Gibson
2019-08-09 9:29 ` Igor Mammedov
2019-08-08 8:17 ` Tao Xu
2019-09-03 17:52 ` Eduardo Habkost
2019-09-04 6:22 ` Tao Xu
2019-09-04 20:43 ` Eduardo Habkost [this message]
2019-09-05 0:57 ` Tao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904204347.GC4617@habkost.net \
--to=ehabkost@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=tao3.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).