From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D05C5ACAE for ; Wed, 11 Sep 2019 13:51:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0F192089F for ; Wed, 11 Sep 2019 13:51:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0F192089F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i831p-0008KY-9g for qemu-devel@archiver.kernel.org; Wed, 11 Sep 2019 09:51:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35758) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i830x-0007nZ-AK for qemu-devel@nongnu.org; Wed, 11 Sep 2019 09:50:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i830w-0002ct-7r for qemu-devel@nongnu.org; Wed, 11 Sep 2019 09:50:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54822) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i830u-0002au-1F; Wed, 11 Sep 2019 09:50:28 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30259368FF; Wed, 11 Sep 2019 13:50:27 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3B705C21E; Wed, 11 Sep 2019 13:50:16 +0000 (UTC) Date: Wed, 11 Sep 2019 15:50:15 +0200 From: Igor Mammedov To: Peter Maydell Message-ID: <20190911155015.3627b072@redhat.com> In-Reply-To: References: <20190904085629.13872-1-shameerali.kolothum.thodi@huawei.com> <20190904085629.13872-11-shameerali.kolothum.thodi@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 11 Sep 2019 13:50:27 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Ortiz , Ard Biesheuvel , mst@redhat.com, QEMU Developers , Xu Wei , Linuxarm , Shannon Zhao , qemu-arm , Shameer Kolothum , Eric Auger , sebastien.boeuf@intel.com, Laszlo Ersek Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 11 Sep 2019 13:57:06 +0100 Peter Maydell wrote: > On Wed, 4 Sep 2019 at 09:58, Shameer Kolothum > wrote: > > > > This patch is in preparation for adding numamem and memhp tests > > to arm/virt board so that 'make check' is happy. This may not > > be required once the scripts are run and new tables are > > generated with ".numamem" and ".memhp" extensions. > > > > Signed-off-by: Shameer Kolothum > > --- > > I am not sure this is the right way to do this. But without this, when > > the numamem and memhp tests are added, you will get, > > > > Looking for expected file 'tests/data/acpi/virt/SRAT.numamem' > > Looking for expected file 'tests/data/acpi/virt/SRAT' > > ** > > ERROR:tests/bios-tables-test.c:327:load_expected_aml: assertion failed: (exp_sdt.aml_file) > > > > --- > > tests/data/acpi/virt/SLIT | Bin 0 -> 48 bytes > > tests/data/acpi/virt/SRAT | Bin 0 -> 224 bytes > > 2 files changed, 0 insertions(+), 0 deletions(-) > > create mode 100644 tests/data/acpi/virt/SLIT > > create mode 100644 tests/data/acpi/virt/SRAT > > Do the tests pass with this patch and without the > patch that adds the tests? (That is, can we keep the > two patches separate without breaking bisection, or > do we need to squash them together?) > > I'll leave it to somebody who understands the ACPI > tests stuff to answer whether there's a better way to I'd squash this patch into 11/11 test case, CCing Michael (since he's the one who applies ACPI patches) > do this. > > thanks > -- PMM >