From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6DBCC49ED6 for ; Wed, 11 Sep 2019 17:26:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCD492084F for ; Wed, 11 Sep 2019 17:26:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCD492084F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i86NT-00031D-Pj for qemu-devel@archiver.kernel.org; Wed, 11 Sep 2019 13:25:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50131) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i86Mi-0002U0-US for qemu-devel@nongnu.org; Wed, 11 Sep 2019 13:25:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i86Mh-00048T-RY for qemu-devel@nongnu.org; Wed, 11 Sep 2019 13:25:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36612) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i86Mh-00048J-MZ for qemu-devel@nongnu.org; Wed, 11 Sep 2019 13:25:11 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 09D441057875 for ; Wed, 11 Sep 2019 17:25:11 +0000 (UTC) Received: from work-vm (ovpn-117-243.ams2.redhat.com [10.36.117.243]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 073B95D9E2; Wed, 11 Sep 2019 17:25:09 +0000 (UTC) Date: Wed, 11 Sep 2019 18:25:07 +0100 From: "Dr. David Alan Gilbert" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Message-ID: <20190911172507.GL2894@work-vm> References: <20190911164202.31136-1-dgilbert@redhat.com> <20190911164202.31136-3-dgilbert@redhat.com> <20190911165938.GI24295@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190911165938.GI24295@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Wed, 11 Sep 2019 17:25:11 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 2/3] migration: Use automatic rcu_read unlock in ram.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Daniel P. Berrang=E9 (berrange@redhat.com) wrote: > On Wed, Sep 11, 2019 at 05:42:01PM +0100, Dr. David Alan Gilbert (git) = wrote: > > From: "Dr. David Alan Gilbert" > >=20 > > Use the automatic read unlocker in migration/ram.c; > > only for the cases where the unlock is at the end of the function. > >=20 > > Signed-off-by: Dr. David Alan Gilbert > > --- > > migration/ram.c | 25 +++++++++---------------- > > 1 file changed, 9 insertions(+), 16 deletions(-) > >=20 > > diff --git a/migration/ram.c b/migration/ram.c > > index b2bd618a89..750d198f37 100644 > > --- a/migration/ram.c > > +++ b/migration/ram.c > > @@ -181,14 +181,14 @@ int foreach_not_ignored_block(RAMBlockIterFunc = func, void *opaque) > > RAMBlock *block; > > int ret =3D 0; > > =20 > > - rcu_read_lock(); > > + RCU_READ_LOCK_AUTO >=20 > FWIW, I'm not a fan of macros which are used without a trailing ';' > as I believe it can confuses editors' code indentation logic. Added. >=20 > Regards, > Daniel > --=20 > |: https://berrange.com -o- https://www.flickr.com/photos/dberr= ange :| > |: https://libvirt.org -o- https://fstop138.berrange= .com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberr= ange :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK