From: Wei Yang <richardw.yang@linux.intel.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
rth@twiddle.net, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc()
Date: Thu, 12 Sep 2019 10:51:50 +0800 [thread overview]
Message-ID: <20190912025150.GA25169@richard> (raw)
In-Reply-To: <20190823010750.GA21179@richard>
On Fri, Aug 23, 2019 at 09:07:50AM +0800, Wei Yang wrote:
>On Thu, Aug 22, 2019 at 12:24:32PM +0200, Paolo Bonzini wrote:
>>On 21/03/19 09:25, Wei Yang wrote:
>>> PHYS_MAP_NODE_NIL is assigned to PhysPageEntry.ptr in case this is not a
>>> leaf entry, while map->nodes_nb range in [0, nodes_nb_alloc).
>>>
>>> Seems we are asserting on two different things, just remove it.
>>
>>The assertion checks that this "if" is not entered incorrectly:
>>
>> if (lp->skip && lp->ptr == PHYS_MAP_NODE_NIL) {
>> lp->ptr = phys_map_node_alloc(map, level == 0);
>> }
>>
>
>Hmm... I may not get your point.
>
>phys_map_node_alloc() will get an available PhysPageEntry and return its
>index, which will be assigned to its parent's ptr.
>
>The "if" checks on the parent's ptr, while the assertion asserts the index for
>the new child. I may miss something?
>
Hi, Paolo,
Do I miss something?
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-09-12 2:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190321082555.21118-1-richardw.yang@linux.intel.com>
2019-04-22 0:59 ` [Qemu-devel] [PATCH 0/6] Refine exec Wei Yang
2019-04-22 0:59 ` Wei Yang
2019-08-19 3:06 ` Wei Yang
2019-08-22 10:25 ` Paolo Bonzini
2019-08-22 22:31 ` Wei Yang
[not found] ` <20190321082555.21118-3-richardw.yang@linux.intel.com>
2019-08-22 10:24 ` [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc() Paolo Bonzini
2019-08-23 1:07 ` Wei Yang
2019-09-12 2:51 ` Wei Yang [this message]
2019-09-12 12:42 ` Paolo Bonzini
2019-09-12 23:02 ` Wei Yang
2019-09-13 9:12 ` Paolo Bonzini
2019-09-16 2:02 ` Wei Yang
2019-09-16 7:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912025150.GA25169@richard \
--to=richardw.yang@linux.intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).