From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7628C49ED9 for ; Thu, 12 Sep 2019 10:23:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD2EF20692 for ; Thu, 12 Sep 2019 10:23:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD2EF20692 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8MGa-0001Fh-CG for qemu-devel@archiver.kernel.org; Thu, 12 Sep 2019 06:23:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54071) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8MEW-0008AO-Fz for qemu-devel@nongnu.org; Thu, 12 Sep 2019 06:21:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8MEV-0008Hs-HL for qemu-devel@nongnu.org; Thu, 12 Sep 2019 06:21:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59798) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i8MEV-0008HU-CR for qemu-devel@nongnu.org; Thu, 12 Sep 2019 06:21:47 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B92D53082D9E for ; Thu, 12 Sep 2019 10:21:46 +0000 (UTC) Received: from work-vm (unknown [10.36.118.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 866E81001B09; Thu, 12 Sep 2019 10:21:42 +0000 (UTC) Date: Thu, 12 Sep 2019 11:21:40 +0100 From: "Dr. David Alan Gilbert" To: Peter Xu Message-ID: <20190912102140.GF7230@work-vm> References: <20190906130103.20961-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190906130103.20961-1-peterx@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 12 Sep 2019 10:21:46 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Xiaohui Li , qemu-devel@nongnu.org, Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Peter Xu (peterx@redhat.com) wrote: > We've got max-postcopy-bandwidth parameter but it's not applied > correctly after a postcopy recovery so the recovered migration stream > will still eat the whole net bandwidth. Fix that up. > > Reported-by: Xiaohui Li > Signed-off-by: Peter Xu Queued > --- > migration/migration.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/migration/migration.c b/migration/migration.c > index 8b9f2fe30a..b307813aa3 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -3327,7 +3327,8 @@ void migrate_fd_connect(MigrationState *s, Error *error_in) > > if (resume) { > /* This is a resumed migration */ > - rate_limit = INT64_MAX; > + rate_limit = s->parameters.max_postcopy_bandwidth / > + XFER_LIMIT_RATIO; > } else { > /* This is a fresh new migration */ > rate_limit = s->parameters.max_bandwidth / XFER_LIMIT_RATIO; > -- > 2.21.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK