Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

On Wed, Sep 11, 2019 at 05:36:32PM +0200, Johannes Berg wrote:
> On Wed, 2019-09-11 at 17:31 +0200, Stefan Hajnoczi wrote:
> 
> > > +``VHOST_USER_VQ_CALL``
> > 
> > "call" should be "kick".  "kick" is the driver->device request
> > submission notification and "call" is the device->driver request
> > completion notification.
> 
> Ahrg, yes. I confuse this all the time, sorry, will fix.
> 
> Btw, speaking of confusion ... this document may need some cleanup wrt.
> the "client" language since it states that both sides might be a socket
> server or client, but then goes on to talk about the "client" as though
> it was equivalent to "slave", where normally it's actually the other way
> around (the device is the one listening on the socket, i.e. it's the
> server). This is most pronounced in the section "Starting and stopping
> rings".
> 
> IMHO, it'd be good to talk more about "device" and "host" instead of
> "slave" and "master" too since that's clearer, and just replace *all*
> that language accordingly, but YMMV.

The vhost-user spec is unclear and inconsistent.  Patches are welcome.
A footnote describing the old terminology would be necessary so that
existing documentation, code, etc can still be decyphered when the spec
changes the terminology :).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]