From: David Gibson <david@gibson.dropbear.id.au>
To: Balamuruhan S <bala24@linux.ibm.com>
Cc: maddy@linux.vnet.ibm.com, groug@kaod.org, qemu-devel@nongnu.org,
anju@linux.vnet.ibm.com, qemu-ppc@nongnu.org, clg@kaod.org,
hari@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3 0/4] add Homer/OCC common area emulation for PowerNV
Date: Mon, 16 Sep 2019 10:36:39 +1000 [thread overview]
Message-ID: <20190916003639.GD2104@umbus.fritz.box> (raw)
In-Reply-To: <20190912093056.4516-1-bala24@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 3343 bytes --]
On Thu, Sep 12, 2019 at 03:00:51PM +0530, Balamuruhan S wrote:
> Hi All,
>
> This is follow-up patch that implements HOMER and OCC SRAM device
> models to emulate homer memory and occ common area access for pstate
> table, occ sensors, runtime data and slw.
>
> Currently skiboot disables the homer/occ code path with `QUIRK_NO_PBA`,
> this quirk have to be removed in skiboot for it to use HOMER and OCC
> SRAM device models along with a bug fix,
>
> https://github.com/balamuruhans/skiboot/commit/a655514d2a730e0372a2faee277d1cf01f71a524
> https://github.com/balamuruhans/skiboot/commit/fd3d93d92ec66a7494346d6d24ced7b48264c9a0
>
> This version fixes a review comment from Cedric in previous version,
Applied to ppc-for-4.2, thanks.
>
> changes in v3:
> * pass on PnvHomer *homer directly to core_max_array() function
> from the caller.
>
> v2 patchset:
> https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg02231.html
>
> changes in v2:
> * change to PnvHomer/PnvHomerClass instead of PnvHOMER/PnvHOMERClass
> for better code readabililty.
> * fabric link to chip to use `nr_cores` from PnvChip struct for
> core_max_array() as we need to consider active cores in chip and not
> whole machine.
> * declare variable well ahead instead in for() loop syntax to make
> all compilers happy.
> * change to shorter variable name to `hmrc` instead of `homer_class`.
> * remove `homer_` prefix for regs as it is not useful.
> * have separate commit for checkpatch.pl coding style warnings.
>
> v1 patchset:
> https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg01610.html
>
> changes in v1:
> * breaks it to have separate patch series for Homer and OCC
> emulation.
> * reuse PnvOCC device model to implement SRAM device.
> * implement PnvHomer as separate device model.
> * have core max base address as part of PnvHOMERClass.
> * reuse PNV_CHIP_INDEX() instead of introducing new `chip_num`.
> * define all the memory ops access address as macros.
> * few coding style warnings given by checkpatch.pl.
>
> rfc patchset:
> https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg00979.html
>
> I request for review, comments and suggestions for the changes.
>
> Balamuruhan S (4):
> hw/ppc/pnv_xscom: retrieve homer/occ base address from PBA BARs
> hw/ppc/pnv_occ: add sram device model for occ common area
> hw/ppc/pnv_homer: add PowerNV homer device model
> hw/ppc/pnv: fix checkpatch.pl coding style warnings
>
> hw/ppc/Makefile.objs | 1 +
> hw/ppc/pnv.c | 87 ++++++++++++---
> hw/ppc/pnv_homer.c | 272 +++++++++++++++++++++++++++++++++++++++++++++
> hw/ppc/pnv_occ.c | 78 +++++++++++++
> hw/ppc/pnv_xscom.c | 34 +++++-
> include/hw/ppc/pnv.h | 21 ++++
> include/hw/ppc/pnv_homer.h | 53 +++++++++
> include/hw/ppc/pnv_occ.h | 3 +
> 8 files changed, 528 insertions(+), 21 deletions(-)
> create mode 100644 hw/ppc/pnv_homer.c
> create mode 100644 include/hw/ppc/pnv_homer.h
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-09-16 0:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 9:30 [Qemu-devel] [PATCH v3 0/4] add Homer/OCC common area emulation for PowerNV Balamuruhan S
2019-09-12 9:30 ` [Qemu-devel] [PATCH v3 1/4] hw/ppc/pnv_xscom: retrieve homer/occ base address from PBA BARs Balamuruhan S
2019-09-12 9:30 ` [Qemu-devel] [PATCH v3 2/4] hw/ppc/pnv_occ: add sram device model for occ common area Balamuruhan S
2019-09-12 9:30 ` [Qemu-devel] [PATCH v3 3/4] hw/ppc/pnv_homer: add PowerNV homer device model Balamuruhan S
2019-09-12 9:51 ` Cédric Le Goater
2019-09-12 9:30 ` [Qemu-devel] [PATCH v3 4/4] hw/ppc/pnv: fix checkpatch.pl coding style warnings Balamuruhan S
2019-09-12 9:54 ` [Qemu-devel] [PATCH v3 0/4] add Homer/OCC common area emulation for PowerNV Cédric Le Goater
2019-09-12 10:20 ` Balamuruhan S
2019-09-16 0:36 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916003639.GD2104@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=anju@linux.vnet.ibm.com \
--cc=bala24@linux.ibm.com \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=hari@linux.vnet.ibm.com \
--cc=maddy@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).